Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView and semantics #14

Closed
sjaakp opened this issue Mar 19, 2019 · 5 comments
Closed

ListView and semantics #14

sjaakp opened this issue Mar 19, 2019 · 5 comments
Assignees
Milestone

Comments

@sjaakp
Copy link

sjaakp commented Mar 19, 2019

In an attempt to write semantical correct HTML I used a ListView with:

'options' => [ 'tag' => 'ol' ], 'itemOptions' => [ 'tag' => 'li' ]

However, I learned that the summary and the pager appeared inside the OL, like a kind of list items, which they are certainly not.

Of course, there are ways to work around this, such as overriding renderItems(), but it occurs to me that there must be a simpler way to get a semantical correct list out of ListView.

Perhaps something to consider for Yii3?

@glpzzz
Copy link
Contributor

glpzzz commented Aug 10, 2024

Hello, I just notice I have a WIP about this. Just the changes on tests required to finish.

Is this something worth working on? The proposed change goes around modifying the default layout to use ul/li instead of generics divs.

@vjik
Copy link
Member

vjik commented Aug 11, 2024

I like this suggestion

@samdark samdark added this to the 1.0 milestone Aug 11, 2024
@samdark
Copy link
Member

samdark commented Aug 11, 2024

Is this something worth working on?

Yes, please do.

@vjik
Copy link
Member

vjik commented Sep 2, 2024

@glpzzz Any news? Maybe you need help?

@glpzzz
Copy link
Contributor

glpzzz commented Sep 2, 2024

Starting today I have some available days.

EDIT: yes, as I remember, a lot of tests to work on...

glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 7, 2024
glpzzz added a commit to glpzzz/yii-dataview that referenced this issue Sep 8, 2024
Tests also modified. The extra \n is not a problem and expected.
@samdark samdark closed this as completed in b504e0c Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants