-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListView and semantics #14
Comments
Hello, I just notice I have a WIP about this. Just the changes on tests required to finish. Is this something worth working on? The proposed change goes around modifying the default layout to use ul/li instead of generics divs. |
I like this suggestion |
Yes, please do. |
@glpzzz Any news? Maybe you need help? |
Starting today I have some available days. EDIT: yes, as I remember, a lot of tests to work on... |
…items wrapper element.
…ent for each item.
Tests also modified. The extra \n is not a problem and expected.
In an attempt to write semantical correct HTML I used a
ListView
with:'options' => [ 'tag' => 'ol' ], 'itemOptions' => [ 'tag' => 'li' ]
However, I learned that the summary and the pager appeared inside the OL, like a kind of list items, which they are certainly not.
Of course, there are ways to work around this, such as overriding
renderItems()
, but it occurs to me that there must be a simpler way to get a semantical correct list out ofListView
.Perhaps something to consider for Yii3?
The text was updated successfully, but these errors were encountered: