Fix #14: Use ul and li tags for the default layout of the ListView
#210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
============================================
+ Coverage 64.66% 68.07% +3.41%
- Complexity 558 569 +11
============================================
Files 46 45 -1
Lines 1862 1848 -14
============================================
+ Hits 1204 1258 +54
+ Misses 658 590 -68 ☔ View full report in Codecov by Sentry. |
|
Are the missing quotes a desired thing on
This expected output for the test is the result of rendering https://github.com/yiisoft/yii-dataview/blob/848da41ead3407cea7a3647e8db66058d9a33708/tests/Support/view/_listviewparams.php which don't have the quotes. |
…14-listview-and-semantics
…14-listview-and-semantics
…14-listview-and-semantics
…items wrapper element.
|
WIP: Need to make the LI tag also configurable for the |
| @@ -76,12 +80,14 @@ public function testItemViewAsString(): void | |||
| Assert::equalsWithoutLE( | |||
| <<<HTML | |||
| <div> | |||
| <div> | |||
| <ul> | |||
| <li> | |||
| <div>Id: 1</div><div>Name: John</div><div>Age: 20</div> | |||
There was a problem hiding this comment.
I think <span> is more suitable here considering <li>.
There was a problem hiding this comment.
We need to separate items somehow. With div is break line.
src/ListView.php
Outdated
| } | ||
|
|
||
| return Div::tag() | ||
| return Li::tag() |
There was a problem hiding this comment.
Item tag should be customizeable also.
There was a problem hiding this comment.
Yes, I'm working on it
|
@glpzzz sounds like a good idea. |
Tests also modified. The extra \n is not a problem and expected.
samdark
changed the title
ul and li tags for the default layout of the ListView.ul and li tags for the default layout of the ListView
|
👍 |
As per commented on #14,
ulandlitags are used for the default layout of the ListView.