Fix #211: ListView::itemViewAttributes() accepts Closure as parameter. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 64.66% 68.17% +3.51%
- Complexity 558 572 +14
============================================
Files 46 45 -1
Lines 1862 1854 -8
============================================
+ Hits 1204 1264 +60
+ Misses 658 590 -68 ☔ View full report in Codecov by Sentry. |
vjik
requested changes
Sep 8, 2024
glpzzz
changed the title
ListView::itemViewAttributes() accepts Closure as parameter.ListView::itemViewAttributes() accepts Closure as parameter.
glpzzz
changed the title
ListView::itemViewAttributes() accepts Closure as parameter.
samdark
requested changes
Sep 9, 2024
glpzzz
changed the title
…rameter-for-listview-itemviewattributes # Conflicts: # src/ListView.php # tests/ListView/BaseTest.php
samdark
reviewed
Sep 9, 2024
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
approved these changes
Sep 10, 2024
|
@vjik I think everything is addressed. Please re-check. |
vjik
approved these changes
Sep 10, 2024
|
@glpzzz Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #211