Maya: Remove some unused code

[BigRoy]

Brief description

First pass at cleaning up some dead Maya integration code, as a step for #1306

Notes

The following functions also appear unused - but I wasn't sure whether to remove them.

openpype.hosts.maya.api.lib.without_extension
openpype.hosts.maya.api.lib.remove_id
openpype.hosts.maya.api.lib.unique_name
openpype.hosts.maya.api.lib.no_refresh

The remove_id might be nice to keep in the API for anyone coding against the OP maya integration. The without_extension I wasn't sure about because it was exposed in the __init__ for the API too. The other ones feel like some that we can remove too?

Also, some of the removed code came from Avalon core and had no use in OP.

Testing notes

Still needs to be tested in Maya.

[BigRoy]

Did some quick preliminary testing in Maya. Launches fine, seems to work at first sight. I guess it's just a debate about those last potentially unused methods whether it's worth removing those too.

[antirotor]

As these are not used anywhere and it survived my casual playing with Maya I guess it is safe to merge it.

[BigRoy]

Any verdict on these still remaining functions that appear unusued?

openpype.hosts.maya.api.lib.without_extension
openpype.hosts.maya.api.lib.remove_id
openpype.hosts.maya.api.lib.unique_name
openpype.hosts.maya.api.lib.no_refresh

[tokejepsen]

Is openpype.hosts.maya.api.lib.no_refresh not being used for alembic caching?

[BigRoy]

Is openpype.hosts.maya.api.lib.no_refresh not being used for alembic caching?

No, that is - how confusing it might seem - openpype.hosts.maya.api.lib.suspended_refresh which differs in code from openpype.hosts.maya.api.lib.no_refresh.

If we'd want there's also ogs(pause=True) if we want to pause the Viewport 2.0 Hardware renderer. So much ways to suspend certain aspects from Maya. However do note that unpausing with ogs seems to perform a partial reset/refresh and thus can be slow for large scenes.

[antirotor]

Any verdict on these still remaining functions that appear unusued?

I would remove them too. Even if they might be useful later, I hate idea to have OP as repository for useful but not used code :) Anyway, we have git history and if needed, they can be resurrected.

[antirotor]

btw I love this :)

[BigRoy]

I would remove them too. Even if they might be useful later, I hate idea to have OP as repository for useful but not used code :) Anyway, we have git history and if needed, they can be resurrected.

Agreed. Removed with b52e511

Did some preliminary testing in Maya 2020. Still seemed fine, as expected! 👍

btw I love this :)

Even better now. ♻️

[tokejepsen]

Woop woop! -2932 lines!