This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Houdini: Remove unused code #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Similar to what #2709 does for Maya this tries to remove unused code from the Houdini lib.
Houdini also has
set_idandget_idfunctions similar to Maya that, as far as I know, are unused outside the fact they do seem to "generate" on save callback. Are those used anywhere? Do we ever intend to use them? If not, we might want to drop that logic too. The issue #2723 might shed more light on that but guessing based on how Houdini works the current implemenation of setting the ids isn't that useful anyway.Thoughts?
Testing notes: