This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Hiero: colorspace settings aligned with nuke - AY-978 #6249
Merged
jakubjezek001
merged 9 commits into
develop
from
enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke
Apr 9, 2024
Merged
Hiero: colorspace settings aligned with nuke - AY-978 #6249
jakubjezek001
merged 9 commits into
develop
from
enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
type: enhancement
Enhancements to existing functionality
size/S
Denotes a PR changes 100-499 lines, ignoring general files
host: Hiero
host: Nuke
labels
Mar 25, 2024
@tokejepsen once this is finalized can we create the port into |
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
jakubjezek001
suggested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets apply suggestions so it is ready for merge
This should also have |
jakubjezek001
approved these changes
Apr 9, 2024
tokejepsen
deleted the
enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke
branch
April 10, 2024 06:40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
host: Hiero
host: Nuke
port to AYON
size/S
Denotes a PR changes 100-499 lines, ignoring general files
sponsored
Client endorsed or requested
type: enhancement
Enhancements to existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
In order to share the same colorspaces in the workfile in Hiero and Nuke, we need to bring back the workfile settings for colorspaces in Nuke.
In Hiero we also need code to edit the project settings in memory and apply the colorspaces when launching Hiero so any new project gets the correct colorspaces. Due to Foundry not providing Python API methods for setting the project colorspaces, we need to go through the UI widgets to set them, when dealing with in-memory projects.
Also small bugfix when saving the workfile without any sequences.
Testing notes:
project_settings/global/imageio/activate_global_color_management