Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiero: colorspace settings aligned with nuke - AY-978 #390

Conversation

tokejepsen
Copy link
Member

Changelog Description

Port of ynput/OpenPype#6249

Additional:

  • code cosmetics.
  • Nuke: remove print statements from nuke startup to reduce the clutter.
  • Hiero: bug fix for tags creation, taskType > taskTypes
  • Nuke: added option for setting Output Transform for viewer nodes.

Testing notes:

  1. Reset color management settings for Global, Nuke and Hiero.
  2. Enable Global color management; project_settings/global/imageio/activate_global_color_management
  3. Launch Nuke and Hiero.
  4. Verify the colorspaces are setup correctly.

@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition host: Hiero host: Nuke size/S labels Apr 10, 2024
@moonyuet
Copy link
Member

@tokejepsen would you mind to resolve the conflict?

…ngs-aligned-with-nuke

# Conflicts:
#	server_addon/hiero/server/version.py
#	server_addon/nuke/server/version.py
@tokejepsen
Copy link
Member Author

@moonyuet sure, done.

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colospace config is set correctly as expected in Nuke and Hiero

@moonyuet moonyuet merged commit 4b90d41 into develop Apr 30, 2024
1 check failed
@moonyuet moonyuet deleted the enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke branch April 30, 2024 08:21
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Apr 30, 2024

It's already merged, but it is not backwards compatible... Using older addon with settings will break the code.

@moonyuet moonyuet restored the enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke branch April 30, 2024 08:40
@moonyuet
Copy link
Member

It's already merged, but it is not backwards compatible... Using older addon with settings will break the code.

I wasn't aware of that, (sorry my bad!). I will restore the branch so that @tokejepsen can use the same branch and continue to work on the backwards compatiblity.

@tokejepsen
Copy link
Member Author

It's already merged, but it is not backwards compatible... Using older addon with settings will break the code.

@iLLiCiTiT could you elaborate on this?

@tokejepsen tokejepsen deleted the enhancement/AY-978_hiero-colorspace-settings-aligned-with-nuke branch May 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
host: Nuke size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants