This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Lib from illicit part 1 #681
Merged
kalisp
merged 10 commits into
feature/664-3-0-lib-refactor
from
feature/lib_from_illicit_part_1
Nov 4, 2020
Merged
Lib from illicit part 1 #681
kalisp
merged 10 commits into
feature/664-3-0-lib-refactor
from
feature/lib_from_illicit_part_1
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 11, in sys.exit(main()) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run self.run_serial() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.6/ast.py", line 253, in visit return visitor(node) File "/usr/lib/python3.6/ast.py", line 261, in generic_visit self.visit(item) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.6/ast.py", line 263, in generic_visit self.visit(value) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
Those two PRs should probably be merged first, so we can keep it clean. They need some serious testing though |
Closed
kalisp
approved these changes
Nov 4, 2020
Manually tested replacement of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part of my changes in
pype.lib
. There are more but few functions in current lib have modifications in opened PRs and not sure if should move them?ffprobe_streams
- https://github.com/pypeclub/pype/pull/680/filesBuildWorkfile
- Order automatic workfile build based on presets. #677Changes
CustomNone
- removed, never usedmap_subsets_by_family
is now static function ofBuildWorkfile
class (only place where was used)get_project
- removed, single-line functionget_avalon_database
andset_io_database
- moved todeprecated.py
, they are not used in Pype 3ApplicationLaunchFailed
,launch_application
andApplicationAction
- moved toapplications.py
lib.__init__.py
Question?
pype.lib
contain a lot of functions which are specific for "avalon context",get_project
was one of them,get_linked_assets
,get_asset
,get_hierarchy
etc. Should we keep them in pype lib?