Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

3.0 lib refactor - path tools #697

Merged
merged 9 commits into from
Nov 12, 2020

Conversation

mkolar
Copy link
Member

@mkolar mkolar commented Nov 10, 2020

Another batch of lib cleanup.

  • add_tool_to_environment - wasn't used at all -> removed
  • get_ffmpeg_tool_path - moved to path_tools.py
  • get_last_version_from_path - moved to path_tools.py
  • get_paths_from_environ - moved to path_tools.py
  • get_version_from_path - moved to path_tools.py
  • version_up - moved to path_tools.py
  • _rreplace - private, moved to path_tools.py
  • grouper - moved to extract_camera_mayaScene.py, which was the only place of use
  • pairwise - moved to maya.lib. it's is only used by collect_yeti_rig, so it's more appropriate
  • modified_environ - only used aport and premierePro launcher action, none of which are used anymore - > removed

@iLLiCiTiT could you please take those you were asking about in #681 and process them as well? For now I would move the context and database related function to their own module, to at least keep them contained. BuildWorkfile deservers it's own home too.

@mkolar mkolar requested a review from kalisp November 10, 2020 00:16
@mkolar mkolar added the backend label Nov 10, 2020
@mkolar mkolar self-assigned this Nov 10, 2020
@mkolar mkolar requested a review from a team November 10, 2020 00:17
@mkolar mkolar changed the title Feature/3.0 lib refactor milan 3.0 lib refactor - path tools Nov 10, 2020
kalisp added a commit that referenced this pull request Nov 12, 2020
@kalisp kalisp merged commit 28ad05f into feature/664-3-0-lib-refactor Nov 12, 2020
@mkolar mkolar deleted the feature/3.0_lib_refactor_milan branch December 1, 2020 15:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants