Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:絵文字インポート時に毎回ドライブファイルが生成されないように #362

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

penginn-net
Copy link
Collaborator

@penginn-net penginn-net commented Aug 21, 2024

What

同一ファイルハッシュでも強制的に上げるオプションが有効だったから無効に

Why

Fix #354

Additional info (optional)

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@penginn-net
Copy link
Collaborator Author

@kozakura913 こんな感じ?

Copy link
Contributor

github-actions bot commented Aug 21, 2024

이 PR에 의한 api.json 차이

차이점은 여기에서 볼 수 있음

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.76%. Comparing base (c061a17) to head (cda2e75).
Report is 3 commits behind head on develop.

Files Patch % Lines
...ckend/src/server/api/endpoints/admin/emoji/copy.ts 0.00% 1 Missing ⚠️
...kend/src/server/api/endpoints/admin/emoji/steal.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #362   +/-   ##
========================================
  Coverage    38.75%   38.76%           
========================================
  Files         1655     1655           
  Lines       215978   215984    +6     
  Branches      3727     3735    +8     
========================================
+ Hits         83702    83720   +18     
- Misses      131628   131655   +27     
+ Partials       648      609   -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913
Copy link
Collaborator

たぶん

@penginn-net
Copy link
Collaborator Author

user:nullだとforce見てくれないから別でプルリクはやした #363 がマージされればこれが動く

@penginn-net
Copy link
Collaborator Author

forceはデフォルトfalseだけど明示falseのほうがいい?

@kozakura913
Copy link
Collaborator

明示の方が良さそう

@penginn-net penginn-net marked this pull request as ready for review August 22, 2024 11:57
@penginn-net penginn-net changed the title forceをfalseに Fix:絵文字インポート時に毎回ドライブファイルが生成されないように Aug 22, 2024
@kozakura913 kozakura913 self-requested a review August 23, 2024 05:12
@penginn-net penginn-net merged commit 1087514 into yojo-art:develop Aug 23, 2024
17 of 18 checks passed
@penginn-net penginn-net deleted the emojicopy-force branch August 23, 2024 07:04
@kozakura913 kozakura913 added this to the yojo0.6.0 milestone Aug 23, 2024
@kozakura913 kozakura913 mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

絵文字インポート時に毎回ドライブファイルが生成される
2 participants