-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正 #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
penginn-net
changed the title
Fix: ユーザーnull(System)の場合forceのオプションが適用されないのを修正
Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正
Aug 21, 2024
ファイルが追加される~のがいい? |
にゃーん |
kozakura913
requested changes
Aug 21, 2024
CI落ちてるの気になる |
checkoutできてない? |
コンフリクト直すの忘れてた |
이 PR에 의한 api.json 차이 차이점은 여기에서 볼 수 있음 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #363 +/- ##
============================================
+ Coverage 20.31% 38.75% +18.44%
============================================
Files 782 1655 +873
Lines 116377 215978 +99601
Branches 1085 3734 +2649
============================================
+ Hits 23644 83713 +60069
- Misses 92148 131656 +39508
- Partials 585 609 +24 ☔ View full report in Codecov by Sentry. |
kozakura913
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix: ユーザーnull(System)の場合forceがfalseでも新規追加されるのを修正
Why
systemでもforceを見た方が良い
Additional info (optional)
Checklist