Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search resolution option #436

Merged
merged 10 commits into from
Dec 29, 2023

Conversation

StefanVukovic99
Copy link
Collaborator

Part 3 of #422.
Adds option to not search all substrings of the scanned text, but only whole words.
Most languages need a bigger scan length than Japanese, and this helps keep performance. Can also be used to prevent unrelated terms showing up.

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner December 24, 2023 12:13
Copy link

github-actions bot commented Dec 24, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

ext/js/language/translator.js Outdated Show resolved Hide resolved
types/ext/settings.d.ts Outdated Show resolved Hide resolved
types/ext/translation.d.ts Outdated Show resolved Hide resolved
ext/data/schemas/options-schema.json Outdated Show resolved Hide resolved
ext/js/language/translator.js Outdated Show resolved Hide resolved
@Casheeew Casheeew mentioned this pull request Dec 27, 2023
@StefanVukovic99
Copy link
Collaborator Author

I've added the settings upgrade and updated the test

@toasted-nutbread toasted-nutbread mentioned this pull request Dec 28, 2023
1 task
@djahandarie djahandarie added this pull request to the merge queue Dec 29, 2023
Merged via the queue into yomidevs:master with commit 580983b Dec 29, 2023
6 checks passed
@djahandarie djahandarie added the kind/enhancement The issue or PR is a new feature or request label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants