Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options util updates #475

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

toasted-nutbread
Copy link

@toasted-nutbread toasted-nutbread commented Dec 28, 2023

More simplifications of the options util update process, since this will probably be updated more frequently.

  • Same as with the message handler updates, the async flag is removed on the list of updates because this can be determined from the return value of update functions.
  • The return value is no longer used since it was never used for anything meaningful.
  • Update notes have been moved into the JSDoc comment.

Copy link

github-actions bot commented Dec 28, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@toasted-nutbread toasted-nutbread marked this pull request as ready for review December 29, 2023 03:53
@toasted-nutbread toasted-nutbread requested a review from a team as a code owner December 29, 2023 03:53
@djahandarie djahandarie added this pull request to the merge queue Dec 29, 2023
Merged via the queue into yomidevs:master with commit 6a072df Dec 29, 2023
5 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants