Add new option for disabling validations #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #216 |
keith
force-pushed
the
ks/disable-config-warnings
branch
from
cdb2aa1
to
774bbe8
Compare
yonaskolb
requested changes
Jan 5, 2018
| @@ -52,6 +53,10 @@ public struct ProjectSpec { | |||
| } | |||
| } | |||
|
|
|||
| public enum DisabledValidations: String { | |||
There was a problem hiding this comment.
Let's rename to ValidationType and move to SpecValidation.swift?
| @@ -36,7 +36,7 @@ extension ProjectSpec { | |||
| if !(basePath + configFile).exists { | |||
| errors.append(.invalidConfigFile(configFile: configFile, config: config)) | |||
| } | |||
| if getConfig(config) == nil { | |||
| if !options.disabledValidations.contains(.missingConfigs) && getConfig(config) == nil { | |||
There was a problem hiding this comment.
I guess we can also add this check to https://github.com/yonaskolb/XcodeGen/blob/master/Sources/ProjectSpec/SpecValidation.swift#L20
This gives us an entry point for disabling specific project.yml validations that sometimes shouldn't apply. The first example is missingConfigs, which, if you use your .yml file in multiple projects, can be too strict if the projects have different top level configurations.
keith
force-pushed
the
ks/disable-config-warnings
branch
from
774bbe8
to
b6ef82b
Compare
|
Updated! |
yonaskolb
approved these changes
Jan 6, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us an entry point for disabling specific project.yml
validations that sometimes shouldn't apply. The first example is
missingConfigs, which, if you use your .yml file in multiple projects,
can be too strict if the projects have different top level
configurations.