Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missingFiles option to skip checking for config file existence #514

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

elliottwilliams
Copy link
Contributor

In #220 (review), @yonaskolb suggested that XcodeGen could have a validation setting to disable checking for the existence of config files:

We could create a followup PR that disables missingFiles

I'm playing with using XcodeGen from a context where I don't have config files available, so I went ahead and added a missingFiles option to handle this use case.

One question I have is whether missingFiles should imply missingConfigs, or whether you think it makes sense for those two options to remain distinct. Let me know what you think!

@yonaskolb
Copy link
Owner

Thanks for the PR @elliottwilliams!
Perhaps missingFiles is a bit misleading as there are other sorts of files that are required and can cause validation errors, for example source files and dependencies)]. For this case, perhaps it should be called missingConfigFiles. In terms of the existing missingConfigs that is seperate and relates to actual config names.

Could you please add a changelog entry as well?

@elliottwilliams
Copy link
Contributor Author

That makes sense! Renamed to missingConfigFiles.

Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks again! One minor thing in the test and then we’re good to go

Tests/XcodeGenKitTests/ProjectSpecTests.swift Outdated Show resolved Hide resolved
@yonaskolb yonaskolb merged commit 2710a72 into yonaskolb:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants