Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid TreeChanges in concurrent Tree.Style #149

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Jan 18, 2024

What this PR does / why we need it?

Fix invalid TreeChanges in concurrent Tree.Style

Any background context you want to provide?

What are the relevant tickets?

yorkie-team/yorkie-js-sdk#738

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh self-assigned this Jan 18, 2024
@hackerwins
Copy link
Member

hackerwins commented Jan 18, 2024

CC) @justiceHui and @sejongk

@skhugh skhugh reopened this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0c12299) 79.62% compared to head (6b94ba2) 79.62%.

Files Patch % Lines
...c/main/kotlin/dev/yorkie/document/crdt/CrdtTree.kt 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files          63       63           
  Lines        3852     3853    +1     
  Branches      603      603           
=======================================
+ Hits         3067     3068    +1     
  Misses        459      459           
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skhugh skhugh changed the title Add test case for concurrently deleting and styling on same tree path Fix invalid TreeChanges in concurrent Tree.Style Jan 25, 2024
@skhugh skhugh requested a review from 7hong13 January 25, 2024 06:41
@skhugh skhugh merged commit 8661963 into yorkie-team:main Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants