Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid TreeChanges in concurrent Tree.Style #146

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

humdrum
Copy link
Contributor

@humdrum humdrum commented Jan 25, 2024

What this PR does / why we need it?

Fix invalid TreeChanges in concurrent Tree.Style

Any background context you want to provide?

What are the relevant tickets?

Related to yorkie-team/yorkie-android-sdk#149

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@humdrum humdrum self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (b1d58ea) 42.58% compared to head (c9200aa) 42.47%.
Report is 3 commits behind head on main.

Files Patch % Lines
Tests/Integration/TreeIntegrationTests.swift 0.00% 99 Missing ⚠️
Sources/Document/CRDT/CRDTTree.swift 0.00% 10 Missing ⚠️
Sources/Document/Json/JSONTree.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   42.58%   42.47%   -0.12%     
==========================================
  Files         104      104              
  Lines       24276    24340      +64     
==========================================
  Hits        10338    10338              
- Misses      13938    14002      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humdrum humdrum merged commit 33e1f3d into main Jan 25, 2024
3 checks passed
@humdrum humdrum deleted the fix-invalid-concurrent-treechange branch January 25, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants