Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent remote-change events from occurring in push-only mode #161

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

7hong13
Copy link
Contributor

@7hong13 7hong13 commented Mar 12, 2024

What this PR does / why we need it?

In pushOnly mode, a remote-change event can be triggered unexpectedly. This issue occurs when switching from pushPull mode to pushOnly mode before receiving a response to the sync (pushPull) request.
This PR fixes the issue to prevent remote change events from occurring in pushOnly mode.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@7hong13 7hong13 added the bug 🐞 Something isn't working label Mar 12, 2024
@7hong13 7hong13 added this to the 0.4.15 milestone Mar 12, 2024
@7hong13 7hong13 self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (79f4573) to head (acac530).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   79.63%   79.64%   +0.01%     
==========================================
  Files          63       63              
  Lines        3855     3857       +2     
  Branches      606      606              
==========================================
+ Hits         3070     3072       +2     
  Misses        459      459              
  Partials      326      326              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@7hong13 7hong13 merged commit 9d270ac into main Mar 12, 2024
6 checks passed
@7hong13 7hong13 deleted the fix_push_pull branch March 12, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants