Prevent remote-change events from occurring in push-only mode #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing `CRDTTree.edit()`, the edits are reflected by deepcopying the CRDTTreeNodes for the given range. This commit adds information about `insPrevID` and `insNextID` during the `deepcopy()` process to ensure that the correct location is returned from the correct path. --------- Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 81.67% 81.72% +0.05%
==========================================
Files 59 59
Lines 4350 4351 +1
Branches 853 854 +1
==========================================
+ Hits 3553 3556 +3
+ Misses 539 538 -1
+ Partials 258 257 -1 ☔ View full report in Codecov by Sentry. |
hackerwins
requested changes
Mar 7, 2024
hackerwins
reviewed
Mar 7, 2024
hackerwins
changed the title
Merged
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remote change events should not occur in PushOnly mode.
Any background context you want to provide?
What are the relevant tickets?
Fixes #758
Checklist