-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent remote-change events from occurring in push-only mode #759
Conversation
When performing `CRDTTree.edit()`, the edits are reflected by deepcopying the CRDTTreeNodes for the given range. This commit adds information about `insPrevID` and `insNextID` during the `deepcopy()` process to ensure that the correct location is returned from the correct path. --------- Co-authored-by: Yourim Cha <yourim.cha@navercorp.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 81.67% 81.72% +0.05%
==========================================
Files 59 59
Lines 4350 4351 +1
Branches 853 854 +1
==========================================
+ Hits 3553 3556 +3
+ Misses 539 538 -1
+ Partials 258 257 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
I left some simple comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What this PR does / why we need it?
Remote change events should not occur in PushOnly mode.
Any background context you want to provide?
What are the relevant tickets?
Fixes #758
Checklist