Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrent editing test cases in Tree #710

Merged

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Dec 15, 2023

What this PR does / why we need it?

This PR enhances test coverage for concurrent editing in Tree CRDT.
The 7 skipped tests correspond to the TODOs within the Tree implementation.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@sejongk sejongk marked this pull request as draft December 15, 2023 09:41
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7368454) 81.75% compared to head (4994f05) 81.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   81.75%   81.80%   +0.04%     
==========================================
  Files          57       57              
  Lines        4161     4161              
  Branches      805      805              
==========================================
+ Hits         3402     3404       +2     
+ Misses        502      501       -1     
+ Partials      257      256       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejongk sejongk marked this pull request as ready for review January 4, 2024 02:42
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants