Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrent editing test cases in Tree #751

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

sejongk
Copy link
Contributor

@sejongk sejongk commented Jan 8, 2024

What this PR does / why we need it:
This PR enhances test coverage for concurrent editing in Tree CRDT.
The 9 skipped tests correspond to the TODOs within the Tree implementation.

Related to the following PRs in JS-SDK

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@sejongk sejongk marked this pull request as draft January 8, 2024 05:14
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b712df) 49.30% compared to head (ec2b47c) 49.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #751   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files          69       69           
  Lines       10094    10094           
=======================================
  Hits         4977     4977           
  Misses       4601     4601           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejongk sejongk marked this pull request as ready for review January 8, 2024 05:41
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 0d6f5c3 into main Jan 10, 2024
3 checks passed
@hackerwins hackerwins deleted the add-concurrent-editing-cases-in-tree branch January 10, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants