Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v0.5.1 #910

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update CHANGELOG.md for v0.5.1 #910

merged 1 commit into from
Oct 15, 2024

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Oct 15, 2024

What this PR does / why we need it?

Update CHANGELOG.md for v0.5.1

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Introduced a configurable retry mechanism for the broadcast interface.
  • Changed

    • Updated methods to perform splay operations for improved performance.
    • Restricted presence object type to only allow JSON serializable values.
  • Bug Fixes

    • Automated linting to prevent CI failures.
  • Chores

    • Updated version number to 0.5.1 in the package.

Copy link

coderabbitai bot commented Oct 15, 2024

Walkthrough

The pull request introduces updates to the CHANGELOG.md and package.json files for the yorkie-js-sdk package. The CHANGELOG.md now includes a new release entry for version 0.5.1, detailing changes in functionality, including a configurable retry mechanism, modifications to certain methods, and automated linting fixes. The package.json file reflects the version increment from 0.5.0 to 0.5.1 without any other structural changes.

Changes

File Change Summary
CHANGELOG.md Added entry for version 0.5.1, detailing changes: added configurable retry mechanism, updated methods for splay operation, restricted presence object type to JSON serializable values, automated linting fixes.
packages/sdk/package.json Updated version from 0.5.0 to 0.5.1.

Possibly related PRs

  • Update CHANGELOG.md for v0.5.0 #894: This PR updates the CHANGELOG.md for version 0.5.0, which is directly related to the main PR that updates the CHANGELOG.md for version 0.5.1. Both PRs involve changes to the same file and are part of the same versioning sequence.

Poem

In the garden of code, where the bunnies play,
A new version hops in, brightening the day.
With retries and fixes, oh what a delight,
Our SDK's growing, taking flight!
So let’s celebrate, with a joyful cheer,
For every small change brings the future near! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

10-23: LGTM! New version entry added correctly.

The new version 0.5.1 entry has been added with the correct date and follows the established format. The changes are well-categorized into Added, Changed, and Fixed sections, providing clear information about the updates in this version.

However, there are a few minor improvements we can make:

  1. Consider adding hyperlinks to the GitHub usernames and pull request numbers for easier navigation.
  2. The Markdownlint tool flagged some bare URLs. Let's wrap these in angle brackets to make them proper Markdown links.

Here's a suggested improvement for the URLs:

-https://github.com/yorkie-team/yorkie-js-sdk/pull/901
+<https://github.com/yorkie-team/yorkie-js-sdk/pull/901>

-https://github.com/yorkie-team/yorkie-js-sdk/pull/904
+<https://github.com/yorkie-team/yorkie-js-sdk/pull/904>

-https://github.com/yorkie-team/yorkie-js-sdk/pull/898
+<https://github.com/yorkie-team/yorkie-js-sdk/pull/898>

-https://github.com/yorkie-team/yorkie-js-sdk/pull/896
+<https://github.com/yorkie-team/yorkie-js-sdk/pull/896>

These changes will resolve the Markdownlint warnings and improve the overall formatting of the changelog.

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)


18-18: null
Bare URL used

(MD034, no-bare-urls)


19-19: null
Bare URL used

(MD034, no-bare-urls)


23-23: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 56ba2bb and 82bbfa8.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • packages/sdk/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/sdk/package.json
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

14-14: null
Bare URL used

(MD034, no-bare-urls)


18-18: null
Bare URL used

(MD034, no-bare-urls)


19-19: null
Bare URL used

(MD034, no-bare-urls)


23-23: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (1)
CHANGELOG.md (1)

Line range hint 1-1024: Overall, the CHANGELOG.md file is well-maintained and follows best practices.

The changelog consistently follows the Keep a Changelog format and adheres to Semantic Versioning. Each entry is clearly dated and categorized, making it easy for users to understand the changes in each version. The recent addition of version 0.5.1 maintains this high standard.

To further improve the changelog:

  1. Consider adding a "Changed" section to entries that don't have one, even if it's to state "No significant changes" for consistency.
  2. You might want to add links to compare versions (e.g., [0.5.1]: v0.5.0...v0.5.1) at the bottom of the file for easier navigation between versions.

These suggestions are optional and aimed at enhancing the already well-structured changelog.

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)


18-18: null
Bare URL used

(MD034, no-bare-urls)


19-19: null
Bare URL used

(MD034, no-bare-urls)


23-23: null
Bare URL used

(MD034, no-bare-urls)

@hackerwins hackerwins merged commit b7c769c into main Oct 15, 2024
2 checks passed
@hackerwins hackerwins deleted the 0.5.1 branch October 15, 2024 03:13
JOOHOJANG pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant