Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v0.5.2 #914

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update CHANGELOG.md for v0.5.2 #914

merged 1 commit into from
Oct 22, 2024

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Oct 22, 2024

What this PR does / why we need it?

Update CHANGELOG.md for v0.5.2

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Updated the SDK to target JavaScript ES2020, enhancing compatibility with modern standards.
    • Replaced the Long data type with bigint for improved numerical handling.
  • Documentation

    • Updated the changelog to include version 0.5.2 and highlight significant changes.
    • Revised the path for updating the version number in the MAINTAINING.md document.
  • Chores

    • Incremented the version number in the package.json from 0.5.1 to 0.5.2.

Copy link

coderabbitai bot commented Oct 22, 2024

Walkthrough

The pull request introduces updates to the Yorkie JS SDK, specifically reflecting the new version 0.5.2 in the CHANGELOG.md, which highlights significant changes such as updating the target JavaScript version to ES2020 and replacing the Long data type with bigint. The MAINTAINING.md file has been modified to correct the path for the package.json file. Additionally, the package.json itself has been updated to reflect the new version number from 0.5.1 to 0.5.2.

Changes

File Change Summary
CHANGELOG.md Added entry for version 0.5.2; updated target to ES2020 and replaced Long with bigint.
MAINTAINING.md Updated path for version number in package.json.
packages/sdk/package.json Updated version from 0.5.1 to 0.5.2.

Possibly related PRs

  • Update CHANGELOG.md for v0.5.1 #910: This PR updates the CHANGELOG.md for version 0.5.1, which is directly related to the main PR that introduces version 0.5.2, indicating a continuous progression in the SDK's versioning and documentation.

Poem

In the garden of code, where the bunnies hop,
A new version blooms, with a big leap and pop!
From Long to bigint, we dance in delight,
With ES2020, our future is bright!
So let’s update our paths, and keep things in tune,
For the Yorkie SDK, we’ll sing to the moon! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

14-14: Consider adding more details about the impact of this change

While the change is clearly stated, it would be helpful to add a brief note about the potential impact of updating to ES2020 and replacing Long with bigint. This could include any compatibility considerations or performance improvements.

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)


14-14: Fix bare URL in GitHub pull request link

The static analysis tool flagged a bare URL usage. While this is consistent with the rest of the changelog, it's a good practice to use proper Markdown link syntax for better compatibility and readability.

Consider updating the link to use proper Markdown syntax:

-- Update target to ES2020 and replace Long with bigint by @hackerwins in https://github.com/yorkie-team/yorkie-js-sdk/pull/912
++ Update target to ES2020 and replace Long with bigint by @hackerwins in [#912](https://github.com/yorkie-team/yorkie-js-sdk/pull/912)
🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cdeeef7 and d0ce256.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • MAINTAINING.md (1 hunks)
  • packages/sdk/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • MAINTAINING.md
  • packages/sdk/package.json
🧰 Additional context used
🪛 Markdownlint
CHANGELOG.md

14-14: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (3)
CHANGELOG.md (3)

10-14: LGTM: New version entry added correctly

The new version entry for 0.5.2 has been added correctly, following the established format of the changelog. The date is included, and the changes are categorized under "Changed".

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)


Line range hint 1-1024: Overall, the CHANGELOG.md is well-maintained and up-to-date

The changelog is consistently formatted and provides a clear history of changes to the Yorkie JS SDK. The new entry for version 0.5.2 has been added correctly, and the overall structure follows the Keep a Changelog format. Consider adding more details about the impact of the ES2020 and bigint changes, and updating the URL format for better Markdown compatibility.

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)


14-14: Verify the GitHub pull request link

It's a good practice to ensure that the provided GitHub link is accessible and leads to the correct pull request.

🧰 Tools
🪛 Markdownlint

14-14: null
Bare URL used

(MD034, no-bare-urls)

@hackerwins hackerwins merged commit 5d4ded9 into main Oct 22, 2024
2 checks passed
@hackerwins hackerwins deleted the 0.5.2 branch October 22, 2024 05:14
@coderabbitai coderabbitai bot mentioned this pull request Oct 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant