Apply GCPair to TreeNode, TextNode #866

hackerwins · 2024-05-17T08:06:49Z

What this PR does / why we need it:

Apply GCPair to TreeNode, TextNode

This commit is a follow-up task of #864, applying GCPair for TextNode and TreeNode. Additionally, when generating a document from the root, this commit registers GCPair in the cache.

Which issue(s) this PR fixes:

Address #763

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation:

Checklist:

Added relevant tests or not required
Didn't break anything

github-actions

Go Benchmark

Benchmark suite	Current: `d2ab002`	Previous: `80c614c`	Ratio
`BenchmarkDocument/constructor_test`	`1495` ns/op 1224 B/op 21 allocs/op	`1509` ns/op 1288 B/op 22 allocs/op	`0.99`
`BenchmarkDocument/constructor_test - ns/op`	`1495` ns/op	`1509` ns/op	`0.99`
`BenchmarkDocument/constructor_test - B/op`	`1224` B/op	`1288` B/op	`0.95`
`BenchmarkDocument/constructor_test - allocs/op`	`21` allocs/op	`22` allocs/op	`0.95`
`BenchmarkDocument/status_test`	`862.2` ns/op 1192 B/op 19 allocs/op	`896.2` ns/op 1256 B/op 20 allocs/op	`0.96`
`BenchmarkDocument/status_test - ns/op`	`862.2` ns/op	`896.2` ns/op	`0.96`
`BenchmarkDocument/status_test - B/op`	`1192` B/op	`1256` B/op	`0.95`
`BenchmarkDocument/status_test - allocs/op`	`19` allocs/op	`20` allocs/op	`0.95`
`BenchmarkDocument/equals_test`	`7393` ns/op 6977 B/op 124 allocs/op	`7613` ns/op 7233 B/op 128 allocs/op	`0.97`
`BenchmarkDocument/equals_test - ns/op`	`7393` ns/op	`7613` ns/op	`0.97`
`BenchmarkDocument/equals_test - B/op`	`6977` B/op	`7233` B/op	`0.96`
`BenchmarkDocument/equals_test - allocs/op`	`124` allocs/op	`128` allocs/op	`0.97`
`BenchmarkDocument/nested_update_test`	`16765` ns/op 12058 B/op 260 allocs/op	`16828` ns/op 12187 B/op 262 allocs/op	`1.00`
`BenchmarkDocument/nested_update_test - ns/op`	`16765` ns/op	`16828` ns/op	`1.00`
`BenchmarkDocument/nested_update_test - B/op`	`12058` B/op	`12187` B/op	`0.99`
`BenchmarkDocument/nested_update_test - allocs/op`	`260` allocs/op	`262` allocs/op	`0.99`
`BenchmarkDocument/delete_test`	`22892` ns/op 15284 B/op 339 allocs/op	`25761` ns/op 15411 B/op 341 allocs/op	`0.89`
`BenchmarkDocument/delete_test - ns/op`	`22892` ns/op	`25761` ns/op	`0.89`
`BenchmarkDocument/delete_test - B/op`	`15284` B/op	`15411` B/op	`0.99`
`BenchmarkDocument/delete_test - allocs/op`	`339` allocs/op	`341` allocs/op	`0.99`
`BenchmarkDocument/object_test`	`8480` ns/op 6753 B/op 118 allocs/op	`8583` ns/op 6881 B/op 120 allocs/op	`0.99`
`BenchmarkDocument/object_test - ns/op`	`8480` ns/op	`8583` ns/op	`0.99`
`BenchmarkDocument/object_test - B/op`	`6753` B/op	`6881` B/op	`0.98`
`BenchmarkDocument/object_test - allocs/op`	`118` allocs/op	`120` allocs/op	`0.98`
`BenchmarkDocument/array_test`	`28784` ns/op 11883 B/op 274 allocs/op	`29155` ns/op 12011 B/op 276 allocs/op	`0.99`
`BenchmarkDocument/array_test - ns/op`	`28784` ns/op	`29155` ns/op	`0.99`
`BenchmarkDocument/array_test - B/op`	`11883` B/op	`12011` B/op	`0.99`
`BenchmarkDocument/array_test - allocs/op`	`274` allocs/op	`276` allocs/op	`0.99`
`BenchmarkDocument/text_test`	`30604` ns/op 14651 B/op 467 allocs/op	`30956` ns/op 15044 B/op 472 allocs/op	`0.99`
`BenchmarkDocument/text_test - ns/op`	`30604` ns/op	`30956` ns/op	`0.99`
`BenchmarkDocument/text_test - B/op`	`14651` B/op	`15044` B/op	`0.97`
`BenchmarkDocument/text_test - allocs/op`	`467` allocs/op	`472` allocs/op	`0.99`
`BenchmarkDocument/text_composition_test`	`29214` ns/op 18358 B/op 482 allocs/op	`28949` ns/op 18558 B/op 481 allocs/op	`1.01`
`BenchmarkDocument/text_composition_test - ns/op`	`29214` ns/op	`28949` ns/op	`1.01`
`BenchmarkDocument/text_composition_test - B/op`	`18358` B/op	`18558` B/op	`0.99`
`BenchmarkDocument/text_composition_test - allocs/op`	`482` allocs/op	`481` allocs/op	`1.00`
`BenchmarkDocument/rich_text_test`	`79827` ns/op 38413 B/op 1146 allocs/op	`80522` ns/op 38804 B/op 1151 allocs/op	`0.99`
`BenchmarkDocument/rich_text_test - ns/op`	`79827` ns/op	`80522` ns/op	`0.99`
`BenchmarkDocument/rich_text_test - B/op`	`38413` B/op	`38804` B/op	`0.99`
`BenchmarkDocument/rich_text_test - allocs/op`	`1146` allocs/op	`1151` allocs/op	`1.00`
`BenchmarkDocument/counter_test`	`17241` ns/op 10658 B/op 242 allocs/op	`17479` ns/op 10786 B/op 244 allocs/op	`0.99`
`BenchmarkDocument/counter_test - ns/op`	`17241` ns/op	`17479` ns/op	`0.99`
`BenchmarkDocument/counter_test - B/op`	`10658` B/op	`10786` B/op	`0.99`
`BenchmarkDocument/counter_test - allocs/op`	`242` allocs/op	`244` allocs/op	`0.99`
`BenchmarkDocument/text_edit_gc_100`	`1183493` ns/op 870769 B/op 16687 allocs/op	`2880524` ns/op 1658735 B/op 17097 allocs/op	`0.41`
`BenchmarkDocument/text_edit_gc_100 - ns/op`	`1183493` ns/op	`2880524` ns/op	`0.41`
`BenchmarkDocument/text_edit_gc_100 - B/op`	`870769` B/op	`1658735` B/op	`0.52`
`BenchmarkDocument/text_edit_gc_100 - allocs/op`	`16687` allocs/op	`17097` allocs/op	`0.98`
`BenchmarkDocument/text_edit_gc_1000`	`48759850` ns/op 50537405 B/op 181606 allocs/op	`228663032` ns/op 144394579 B/op 200995 allocs/op	`0.21`
`BenchmarkDocument/text_edit_gc_1000 - ns/op`	`48759850` ns/op	`228663032` ns/op	`0.21`
`BenchmarkDocument/text_edit_gc_1000 - B/op`	`50537405` B/op	`144394579` B/op	`0.35`
`BenchmarkDocument/text_edit_gc_1000 - allocs/op`	`181606` allocs/op	`200995` allocs/op	`0.90`
`BenchmarkDocument/text_split_gc_100`	`1789193` ns/op 1528642 B/op 15539 allocs/op	`3393028` ns/op 2316917 B/op 16199 allocs/op	`0.53`
`BenchmarkDocument/text_split_gc_100 - ns/op`	`1789193` ns/op	`3393028` ns/op	`0.53`
`BenchmarkDocument/text_split_gc_100 - B/op`	`1528642` B/op	`2316917` B/op	`0.66`
`BenchmarkDocument/text_split_gc_100 - allocs/op`	`15539` allocs/op	`16199` allocs/op	`0.96`
`BenchmarkDocument/text_split_gc_1000`	`112756150` ns/op 135075170 B/op 182081 allocs/op	`299311452` ns/op 228928228 B/op 203996 allocs/op	`0.38`
`BenchmarkDocument/text_split_gc_1000 - ns/op`	`112756150` ns/op	`299311452` ns/op	`0.38`
`BenchmarkDocument/text_split_gc_1000 - B/op`	`135075170` B/op	`228928228` B/op	`0.59`
`BenchmarkDocument/text_split_gc_1000 - allocs/op`	`182081` allocs/op	`203996` allocs/op	`0.89`
`BenchmarkDocument/text_delete_all_10000`	`15288761` ns/op 10183233 B/op 40675 allocs/op	`11074794` ns/op 5810406 B/op 40673 allocs/op	`1.38`
`BenchmarkDocument/text_delete_all_10000 - ns/op`	`15288761` ns/op	`11074794` ns/op	`1.38`
`BenchmarkDocument/text_delete_all_10000 - B/op`	`10183233` B/op	`5810406` B/op	`1.75`
`BenchmarkDocument/text_delete_all_10000 - allocs/op`	`40675` allocs/op	`40673` allocs/op	`1.00`
`BenchmarkDocument/text_delete_all_100000`	`284168079` ns/op 142690284 B/op 411739 allocs/op	`187427366` ns/op 81902749 B/op 411623 allocs/op	`1.52`
`BenchmarkDocument/text_delete_all_100000 - ns/op`	`284168079` ns/op	`187427366` ns/op	`1.52`
`BenchmarkDocument/text_delete_all_100000 - B/op`	`142690284` B/op	`81902749` B/op	`1.74`
`BenchmarkDocument/text_delete_all_100000 - allocs/op`	`411739` allocs/op	`411623` allocs/op	`1.00`
`BenchmarkDocument/text_100`	`221410` ns/op 119971 B/op 5079 allocs/op	`220083` ns/op 120266 B/op 5084 allocs/op	`1.01`
`BenchmarkDocument/text_100 - ns/op`	`221410` ns/op	`220083` ns/op	`1.01`
`BenchmarkDocument/text_100 - B/op`	`119971` B/op	`120266` B/op	`1.00`
`BenchmarkDocument/text_100 - allocs/op`	`5079` allocs/op	`5084` allocs/op	`1.00`
`BenchmarkDocument/text_1000`	`2403390` ns/op 1168958 B/op 50083 allocs/op	`2397913` ns/op 1169253 B/op 50088 allocs/op	`1.00`
`BenchmarkDocument/text_1000 - ns/op`	`2403390` ns/op	`2397913` ns/op	`1.00`
`BenchmarkDocument/text_1000 - B/op`	`1168958` B/op	`1169253` B/op	`1.00`
`BenchmarkDocument/text_1000 - allocs/op`	`50083` allocs/op	`50088` allocs/op	`1.00`
`BenchmarkDocument/array_1000`	`1247741` ns/op 1091362 B/op 11830 allocs/op	`1214131` ns/op 1091460 B/op 11831 allocs/op	`1.03`
`BenchmarkDocument/array_1000 - ns/op`	`1247741` ns/op	`1214131` ns/op	`1.03`
`BenchmarkDocument/array_1000 - B/op`	`1091362` B/op	`1091460` B/op	`1.00`
`BenchmarkDocument/array_1000 - allocs/op`	`11830` allocs/op	`11831` allocs/op	`1.00`
`BenchmarkDocument/array_10000`	`13403259` ns/op 9800587 B/op 120298 allocs/op	`13251263` ns/op 9799924 B/op 120296 allocs/op	`1.01`
`BenchmarkDocument/array_10000 - ns/op`	`13403259` ns/op	`13251263` ns/op	`1.01`
`BenchmarkDocument/array_10000 - B/op`	`9800587` B/op	`9799924` B/op	`1.00`
`BenchmarkDocument/array_10000 - allocs/op`	`120298` allocs/op	`120296` allocs/op	`1.00`
`BenchmarkDocument/array_gc_100`	`151202` ns/op 132668 B/op 1259 allocs/op	`145693` ns/op 132779 B/op 1260 allocs/op	`1.04`
`BenchmarkDocument/array_gc_100 - ns/op`	`151202` ns/op	`145693` ns/op	`1.04`
`BenchmarkDocument/array_gc_100 - B/op`	`132668` B/op	`132779` B/op	`1.00`
`BenchmarkDocument/array_gc_100 - allocs/op`	`1259` allocs/op	`1260` allocs/op	`1.00`
`BenchmarkDocument/array_gc_1000`	`1425020` ns/op 1159160 B/op 12875 allocs/op	`1383187` ns/op 1159220 B/op 12877 allocs/op	`1.03`
`BenchmarkDocument/array_gc_1000 - ns/op`	`1425020` ns/op	`1383187` ns/op	`1.03`
`BenchmarkDocument/array_gc_1000 - B/op`	`1159160` B/op	`1159220` B/op	`1.00`
`BenchmarkDocument/array_gc_1000 - allocs/op`	`12875` allocs/op	`12877` allocs/op	`1.00`
`BenchmarkDocument/counter_1000`	`204427` ns/op 193011 B/op 5769 allocs/op	`197850` ns/op 193141 B/op 5771 allocs/op	`1.03`
`BenchmarkDocument/counter_1000 - ns/op`	`204427` ns/op	`197850` ns/op	`1.03`
`BenchmarkDocument/counter_1000 - B/op`	`193011` B/op	`193141` B/op	`1.00`
`BenchmarkDocument/counter_1000 - allocs/op`	`5769` allocs/op	`5771` allocs/op	`1.00`
`BenchmarkDocument/counter_10000`	`2187631` ns/op 2087944 B/op 59776 allocs/op	`2155338` ns/op 2088069 B/op 59778 allocs/op	`1.01`
`BenchmarkDocument/counter_10000 - ns/op`	`2187631` ns/op	`2155338` ns/op	`1.01`
`BenchmarkDocument/counter_10000 - B/op`	`2087944` B/op	`2088069` B/op	`1.00`
`BenchmarkDocument/counter_10000 - allocs/op`	`59776` allocs/op	`59778` allocs/op	`1.00`
`BenchmarkDocument/object_1000`	`1379695` ns/op 1428088 B/op 9847 allocs/op	`1358327` ns/op 1428062 B/op 9848 allocs/op	`1.02`
`BenchmarkDocument/object_1000 - ns/op`	`1379695` ns/op	`1358327` ns/op	`1.02`
`BenchmarkDocument/object_1000 - B/op`	`1428088` B/op	`1428062` B/op	`1.00`
`BenchmarkDocument/object_1000 - allocs/op`	`9847` allocs/op	`9848` allocs/op	`1.00`
`BenchmarkDocument/object_10000`	`14919410` ns/op 12165623 B/op 100560 allocs/op	`15102675` ns/op 12167329 B/op 100567 allocs/op	`0.99`
`BenchmarkDocument/object_10000 - ns/op`	`14919410` ns/op	`15102675` ns/op	`0.99`
`BenchmarkDocument/object_10000 - B/op`	`12165623` B/op	`12167329` B/op	`1.00`
`BenchmarkDocument/object_10000 - allocs/op`	`100560` allocs/op	`100567` allocs/op	`1.00`
`BenchmarkDocument/tree_100`	`1048997` ns/op 943636 B/op 6099 allocs/op	`1017530` ns/op 943762 B/op 6101 allocs/op	`1.03`
`BenchmarkDocument/tree_100 - ns/op`	`1048997` ns/op	`1017530` ns/op	`1.03`
`BenchmarkDocument/tree_100 - B/op`	`943636` B/op	`943762` B/op	`1.00`
`BenchmarkDocument/tree_100 - allocs/op`	`6099` allocs/op	`6101` allocs/op	`1.00`
`BenchmarkDocument/tree_1000`	`75723500` ns/op 86460253 B/op 60113 allocs/op	`72708723` ns/op 86460361 B/op 60115 allocs/op	`1.04`
`BenchmarkDocument/tree_1000 - ns/op`	`75723500` ns/op	`72708723` ns/op	`1.04`
`BenchmarkDocument/tree_1000 - B/op`	`86460253` B/op	`86460361` B/op	`1.00`
`BenchmarkDocument/tree_1000 - allocs/op`	`60113` allocs/op	`60115` allocs/op	`1.00`
`BenchmarkDocument/tree_10000`	`9434153058` ns/op 8580662096 B/op 600227 allocs/op	`9286510689` ns/op 8580983712 B/op 600244 allocs/op	`1.02`
`BenchmarkDocument/tree_10000 - ns/op`	`9434153058` ns/op	`9286510689` ns/op	`1.02`
`BenchmarkDocument/tree_10000 - B/op`	`8580662096` B/op	`8580983712` B/op	`1.00`
`BenchmarkDocument/tree_10000 - allocs/op`	`600227` allocs/op	`600244` allocs/op	`1.00`
`BenchmarkDocument/tree_delete_all_1000`	`77527654` ns/op 87509996 B/op 75263 allocs/op	`72517697` ns/op 87508394 B/op 75260 allocs/op	`1.07`
`BenchmarkDocument/tree_delete_all_1000 - ns/op`	`77527654` ns/op	`72517697` ns/op	`1.07`
`BenchmarkDocument/tree_delete_all_1000 - B/op`	`87509996` B/op	`87508394` B/op	`1.00`
`BenchmarkDocument/tree_delete_all_1000 - allocs/op`	`75263` allocs/op	`75260` allocs/op	`1.00`
`BenchmarkDocument/tree_edit_gc_100`	`3875336` ns/op 4146714 B/op 15139 allocs/op	`3695077` ns/op 4146783 B/op 15140 allocs/op	`1.05`
`BenchmarkDocument/tree_edit_gc_100 - ns/op`	`3875336` ns/op	`3695077` ns/op	`1.05`
`BenchmarkDocument/tree_edit_gc_100 - B/op`	`4146714` B/op	`4146783` B/op	`1.00`
`BenchmarkDocument/tree_edit_gc_100 - allocs/op`	`15139` allocs/op	`15140` allocs/op	`1.00`
`BenchmarkDocument/tree_edit_gc_1000`	`302496214` ns/op 383743434 B/op 154839 allocs/op	`294693956` ns/op 383744676 B/op 154846 allocs/op	`1.03`
`BenchmarkDocument/tree_edit_gc_1000 - ns/op`	`302496214` ns/op	`294693956` ns/op	`1.03`
`BenchmarkDocument/tree_edit_gc_1000 - B/op`	`383743434` B/op	`383744676` B/op	`1.00`
`BenchmarkDocument/tree_edit_gc_1000 - allocs/op`	`154839` allocs/op	`154846` allocs/op	`1.00`
`BenchmarkDocument/tree_split_gc_100`	`2556884` ns/op 2412395 B/op 11123 allocs/op	`2490882` ns/op 2412650 B/op 11125 allocs/op	`1.03`
`BenchmarkDocument/tree_split_gc_100 - ns/op`	`2556884` ns/op	`2490882` ns/op	`1.03`
`BenchmarkDocument/tree_split_gc_100 - B/op`	`2412395` B/op	`2412650` B/op	`1.00`
`BenchmarkDocument/tree_split_gc_100 - allocs/op`	`11123` allocs/op	`11125` allocs/op	`1.00`
`BenchmarkDocument/tree_split_gc_1000`	`185163713` ns/op 222250301 B/op 121989 allocs/op	`180817937` ns/op 222251580 B/op 121989 allocs/op	`1.02`
`BenchmarkDocument/tree_split_gc_1000 - ns/op`	`185163713` ns/op	`180817937` ns/op	`1.02`
`BenchmarkDocument/tree_split_gc_1000 - B/op`	`222250301` B/op	`222251580` B/op	`1.00`
`BenchmarkDocument/tree_split_gc_1000 - allocs/op`	`121989` allocs/op	`121989` allocs/op	`1`
`BenchmarkRPC/client_to_server`	`375669054` ns/op 16824562 B/op 174496 allocs/op	`376924012` ns/op 16816522 B/op 174449 allocs/op	`1.00`
`BenchmarkRPC/client_to_server - ns/op`	`375669054` ns/op	`376924012` ns/op	`1.00`
`BenchmarkRPC/client_to_server - B/op`	`16824562` B/op	`16816522` B/op	`1.00`
`BenchmarkRPC/client_to_server - allocs/op`	`174496` allocs/op	`174449` allocs/op	`1.00`
`BenchmarkRPC/client_to_client_via_server`	`634452732` ns/op 32739668 B/op 319224 allocs/op	`631453705` ns/op 32259148 B/op 318647 allocs/op	`1.00`
`BenchmarkRPC/client_to_client_via_server - ns/op`	`634452732` ns/op	`631453705` ns/op	`1.00`
`BenchmarkRPC/client_to_client_via_server - B/op`	`32739668` B/op	`32259148` B/op	`1.01`
`BenchmarkRPC/client_to_client_via_server - allocs/op`	`319224` allocs/op	`318647` allocs/op	`1.00`
`BenchmarkRPC/attach_large_document`	`1395215708` ns/op 1919093528 B/op 8873 allocs/op	`1271401280` ns/op 1896278168 B/op 8895 allocs/op	`1.10`
`BenchmarkRPC/attach_large_document - ns/op`	`1395215708` ns/op	`1271401280` ns/op	`1.10`
`BenchmarkRPC/attach_large_document - B/op`	`1919093528` B/op	`1896278168` B/op	`1.01`
`BenchmarkRPC/attach_large_document - allocs/op`	`8873` allocs/op	`8895` allocs/op	`1.00`
`BenchmarkRPC/adminCli_to_server`	`544365046` ns/op 35944760 B/op 289502 allocs/op	`543263202` ns/op 35951464 B/op 289510 allocs/op	`1.00`
`BenchmarkRPC/adminCli_to_server - ns/op`	`544365046` ns/op	`543263202` ns/op	`1.00`
`BenchmarkRPC/adminCli_to_server - B/op`	`35944760` B/op	`35951464` B/op	`1.00`
`BenchmarkRPC/adminCli_to_server - allocs/op`	`289502` allocs/op	`289510` allocs/op	`1.00`
`BenchmarkLocker`	`63.43` ns/op 16 B/op 1 allocs/op	`63.04` ns/op 16 B/op 1 allocs/op	`1.01`
`BenchmarkLocker - ns/op`	`63.43` ns/op	`63.04` ns/op	`1.01`
`BenchmarkLocker - B/op`	`16` B/op	`16` B/op	`1`
`BenchmarkLocker - allocs/op`	`1` allocs/op	`1` allocs/op	`1`
`BenchmarkLockerParallel`	`39.06` ns/op 0 B/op 0 allocs/op	`39.06` ns/op 0 B/op 0 allocs/op	`1`
`BenchmarkLockerParallel - ns/op`	`39.06` ns/op	`39.06` ns/op	`1`
`BenchmarkLockerParallel - B/op`	`0` B/op	`0` B/op	`1`
`BenchmarkLockerParallel - allocs/op`	`0` allocs/op	`0` allocs/op	`1`
`BenchmarkLockerMoreKeys`	`151.8` ns/op 15 B/op 0 allocs/op	`158.9` ns/op 15 B/op 0 allocs/op	`0.96`
`BenchmarkLockerMoreKeys - ns/op`	`151.8` ns/op	`158.9` ns/op	`0.96`
`BenchmarkLockerMoreKeys - B/op`	`15` B/op	`15` B/op	`1`
`BenchmarkLockerMoreKeys - allocs/op`	`0` allocs/op	`0` allocs/op	`1`
`BenchmarkChange/Push_10_Changes`	`3935703` ns/op 121415 B/op 1284 allocs/op	`3948254` ns/op 121391 B/op 1284 allocs/op	`1.00`
`BenchmarkChange/Push_10_Changes - ns/op`	`3935703` ns/op	`3948254` ns/op	`1.00`
`BenchmarkChange/Push_10_Changes - B/op`	`121415` B/op	`121391` B/op	`1.00`
`BenchmarkChange/Push_10_Changes - allocs/op`	`1284` allocs/op	`1284` allocs/op	`1`
`BenchmarkChange/Push_100_Changes`	`14729494` ns/op 570031 B/op 6654 allocs/op	`14836279` ns/op 571249 B/op 6654 allocs/op	`0.99`
`BenchmarkChange/Push_100_Changes - ns/op`	`14729494` ns/op	`14836279` ns/op	`0.99`
`BenchmarkChange/Push_100_Changes - B/op`	`570031` B/op	`571249` B/op	`1.00`
`BenchmarkChange/Push_100_Changes - allocs/op`	`6654` allocs/op	`6654` allocs/op	`1`
`BenchmarkChange/Push_1000_Changes`	`118505227` ns/op 5239502 B/op 63150 allocs/op	`118965909` ns/op 5257841 B/op 63149 allocs/op	`1.00`
`BenchmarkChange/Push_1000_Changes - ns/op`	`118505227` ns/op	`118965909` ns/op	`1.00`
`BenchmarkChange/Push_1000_Changes - B/op`	`5239502` B/op	`5257841` B/op	`1.00`
`BenchmarkChange/Push_1000_Changes - allocs/op`	`63150` allocs/op	`63149` allocs/op	`1.00`
`BenchmarkChange/Pull_10_Changes`	`2920946` ns/op 100725 B/op 1004 allocs/op	`2932489` ns/op 100756 B/op 1004 allocs/op	`1.00`
`BenchmarkChange/Pull_10_Changes - ns/op`	`2920946` ns/op	`2932489` ns/op	`1.00`
`BenchmarkChange/Pull_10_Changes - B/op`	`100725` B/op	`100756` B/op	`1.00`
`BenchmarkChange/Pull_10_Changes - allocs/op`	`1004` allocs/op	`1004` allocs/op	`1`
`BenchmarkChange/Pull_100_Changes`	`4355874` ns/op 265774 B/op 3475 allocs/op	`4395749` ns/op 266204 B/op 3475 allocs/op	`0.99`
`BenchmarkChange/Pull_100_Changes - ns/op`	`4355874` ns/op	`4395749` ns/op	`0.99`
`BenchmarkChange/Pull_100_Changes - B/op`	`265774` B/op	`266204` B/op	`1.00`
`BenchmarkChange/Pull_100_Changes - allocs/op`	`3475` allocs/op	`3475` allocs/op	`1`
`BenchmarkChange/Pull_1000_Changes`	`8653272` ns/op 1493647 B/op 29861 allocs/op	`8642961` ns/op 1493101 B/op 29857 allocs/op	`1.00`
`BenchmarkChange/Pull_1000_Changes - ns/op`	`8653272` ns/op	`8642961` ns/op	`1.00`
`BenchmarkChange/Pull_1000_Changes - B/op`	`1493647` B/op	`1493101` B/op	`1.00`
`BenchmarkChange/Pull_1000_Changes - allocs/op`	`29861` allocs/op	`29857` allocs/op	`1.00`
`BenchmarkSnapshot/Push_3KB_snapshot`	`17255955` ns/op 709430 B/op 6655 allocs/op	`17421466` ns/op 713933 B/op 6655 allocs/op	`0.99`
`BenchmarkSnapshot/Push_3KB_snapshot - ns/op`	`17255955` ns/op	`17421466` ns/op	`0.99`
`BenchmarkSnapshot/Push_3KB_snapshot - B/op`	`709430` B/op	`713933` B/op	`0.99`
`BenchmarkSnapshot/Push_3KB_snapshot - allocs/op`	`6655` allocs/op	`6655` allocs/op	`1`
`BenchmarkSnapshot/Push_30KB_snapshot`	`121756898` ns/op 5552364 B/op 63153 allocs/op	`122818654` ns/op 5676160 B/op 63154 allocs/op	`0.99`
`BenchmarkSnapshot/Push_30KB_snapshot - ns/op`	`121756898` ns/op	`122818654` ns/op	`0.99`
`BenchmarkSnapshot/Push_30KB_snapshot - B/op`	`5552364` B/op	`5676160` B/op	`0.98`
`BenchmarkSnapshot/Push_30KB_snapshot - allocs/op`	`63153` allocs/op	`63154` allocs/op	`1.00`
`BenchmarkSnapshot/Pull_3KB_snapshot`	`6497069` ns/op 922009 B/op 15511 allocs/op	`6523359` ns/op 922821 B/op 15513 allocs/op	`1.00`
`BenchmarkSnapshot/Pull_3KB_snapshot - ns/op`	`6497069` ns/op	`6523359` ns/op	`1.00`
`BenchmarkSnapshot/Pull_3KB_snapshot - B/op`	`922009` B/op	`922821` B/op	`1.00`
`BenchmarkSnapshot/Pull_3KB_snapshot - allocs/op`	`15511` allocs/op	`15513` allocs/op	`1.00`
`BenchmarkSnapshot/Pull_30KB_snapshot`	`15717112` ns/op 7158021 B/op 150102 allocs/op	`15838710` ns/op 7155995 B/op 150106 allocs/op	`0.99`
`BenchmarkSnapshot/Pull_30KB_snapshot - ns/op`	`15717112` ns/op	`15838710` ns/op	`0.99`
`BenchmarkSnapshot/Pull_30KB_snapshot - B/op`	`7158021` B/op	`7155995` B/op	`1.00`
`BenchmarkSnapshot/Pull_30KB_snapshot - allocs/op`	`150102` allocs/op	`150106` allocs/op	`1.00`
`BenchmarkSync/memory_sync_10_test`	`6953` ns/op 1286 B/op 38 allocs/op	`6840` ns/op 1286 B/op 38 allocs/op	`1.02`
`BenchmarkSync/memory_sync_10_test - ns/op`	`6953` ns/op	`6840` ns/op	`1.02`
`BenchmarkSync/memory_sync_10_test - B/op`	`1286` B/op	`1286` B/op	`1`
`BenchmarkSync/memory_sync_10_test - allocs/op`	`38` allocs/op	`38` allocs/op	`1`
`BenchmarkSync/memory_sync_100_test`	`50501` ns/op 8657 B/op 274 allocs/op	`50508` ns/op 8647 B/op 273 allocs/op	`1.00`
`BenchmarkSync/memory_sync_100_test - ns/op`	`50501` ns/op	`50508` ns/op	`1.00`
`BenchmarkSync/memory_sync_100_test - B/op`	`8657` B/op	`8647` B/op	`1.00`
`BenchmarkSync/memory_sync_100_test - allocs/op`	`274` allocs/op	`273` allocs/op	`1.00`
`BenchmarkSync/memory_sync_1000_test`	`587740` ns/op 74012 B/op 2098 allocs/op	`578015` ns/op 74448 B/op 2127 allocs/op	`1.02`
`BenchmarkSync/memory_sync_1000_test - ns/op`	`587740` ns/op	`578015` ns/op	`1.02`
`BenchmarkSync/memory_sync_1000_test - B/op`	`74012` B/op	`74448` B/op	`0.99`
`BenchmarkSync/memory_sync_1000_test - allocs/op`	`2098` allocs/op	`2127` allocs/op	`0.99`
`BenchmarkSync/memory_sync_10000_test`	`7097880` ns/op 736303 B/op 20296 allocs/op	`7329286` ns/op 732876 B/op 20293 allocs/op	`0.97`
`BenchmarkSync/memory_sync_10000_test - ns/op`	`7097880` ns/op	`7329286` ns/op	`0.97`
`BenchmarkSync/memory_sync_10000_test - B/op`	`736303` B/op	`732876` B/op	`1.00`
`BenchmarkSync/memory_sync_10000_test - allocs/op`	`20296` allocs/op	`20293` allocs/op	`1.00`
`BenchmarkTextEditing`	`5298501571` ns/op 3901936448 B/op 18743513 allocs/op	`18326556999` ns/op 9042113568 B/op 19923613 allocs/op	`0.29`
`BenchmarkTextEditing - ns/op`	`5298501571` ns/op	`18326556999` ns/op	`0.29`
`BenchmarkTextEditing - B/op`	`3901936448` B/op	`9042113568` B/op	`0.43`
`BenchmarkTextEditing - allocs/op`	`18743513` allocs/op	`19923613` allocs/op	`0.94`

This comment was automatically generated by workflow using github-action-benchmark.

codecov · 2024-05-17T10:06:22Z

Codecov Report

Attention: Patch coverage is 49.74359% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 50.59%. Comparing base (bd46419) to head (d2ab002).

Files	Patch %	Lines
pkg/document/crdt/tree.go	49.52%	53 Missing ⚠️
pkg/document/crdt/text.go	3.70%	26 Missing ⚠️
pkg/document/crdt/root.go	57.57%	13 Missing and 1 partial ⚠️
pkg/document/crdt/rht.go	0.00%	3 Missing ⚠️
pkg/document/crdt/rga_tree_split.go	91.30%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   50.59%   50.59%   -0.01%     
==========================================
  Files          70       70              
  Lines       10350    10389      +39     
==========================================
+ Hits         5237     5256      +19     
- Misses       4581     4602      +21     
+ Partials      532      531       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

While improving GC structure, we missed removing nodes from internal indexes of Text when purging tombstones(yorkie-team/yorkie#866).

While improving GC structure, we missed removing nodes from internal indexes of Text when purging tombstones(#866). --------- Co-authored-by: Youngteac Hong <susukang98@gmail.com>

hackerwins added 2 commits May 17, 2024 17:06

Apply GCPair to TreeNode

80c614c

Apply GCPair to TextNode

96c46ea

hackerwins changed the title ~~Apply GCPair to TreeNode~~ Apply GCPair to TreeNode, TextNode, Element May 17, 2024

github-actions bot reviewed May 17, 2024

View reviewed changes

hackerwins changed the title ~~Apply GCPair to TreeNode, TextNode, Element~~ Apply GCPair to TreeNode, TextNode May 17, 2024

Register GCPair when creating a document with root

d2ab002

hackerwins marked this pull request as ready for review May 17, 2024 11:55

hackerwins merged commit 28cbd37 into main May 17, 2024
4 checks passed

hackerwins deleted the apply-gc branch May 17, 2024 11:56

raararaara mentioned this pull request May 23, 2024

Apply GCPair to TreeNode, TextNode yorkie-team/yorkie-js-sdk#819

Merged

2 tasks

BrewTestBot mentioned this pull request May 24, 2024

yorkie 0.4.20 Homebrew/homebrew-core#172714

Merged

hackerwins mentioned this pull request Jul 4, 2024

Remove node from indexes during GC yorkie-team/yorkie-js-sdk#860

Merged

2 tasks

raararaara mentioned this pull request Jul 4, 2024

Remove node from index during GC #913

Merged

2 tasks

hackerwins added a commit to yorkie-team/yorkie-js-sdk that referenced this pull request Jul 4, 2024

Remove node from indexes during GC (#860)

d0b3dc3

While improving GC structure, we missed removing nodes from internal indexes of Text when purging tombstones(yorkie-team/yorkie#866).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply GCPair to TreeNode, TextNode #866

Apply GCPair to TreeNode, TextNode #866

hackerwins commented May 17, 2024 •

edited

Loading

github-actions bot left a comment •

edited

Loading

codecov bot commented May 17, 2024 •

edited

Loading

Apply GCPair to TreeNode, TextNode #866

Apply GCPair to TreeNode, TextNode #866

Conversation

hackerwins commented May 17, 2024 • edited Loading

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

Go Benchmark

codecov bot commented May 17, 2024 • edited Loading

Codecov Report

hackerwins commented May 17, 2024 •

edited

Loading

github-actions bot left a comment •

edited

Loading

codecov bot commented May 17, 2024 •

edited

Loading