impl Default for Os and Arch, use in ImageConfiguration::default()
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt()` Hardcoding Linux/x86_64 is a trap because it will silently do the right thing only for users on that platform. Closes: youki-dev#88
cgwalters
commented
Jan 14, 2022
| @@ -227,6 +227,12 @@ impl<'de> Deserialize<'de> for Os { | |||
| } | |||
| } | |||
|
|
|||
| impl Default for Os { | |||
| fn default() -> Self { | |||
| Os::from(std::env::consts::OS) | |||
There was a problem hiding this comment.
I spot checked this and it seems like there's enough overlap with what Rust has in https://doc.rust-lang.org/std/env/consts/constant.OS.html and what OCI (really Go I guess) expects.
OK I just got a link to https://github.com/containerd/containerd/blob/140ecc9247386d3be21616fe285021c081f4ea08/platforms/database.go#L83
which seems to be a key player in this.
Since we can, and this silences a clippy warning.
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 25.26% 25.59% +0.32%
==========================================
Files 20 20
Lines 1488 1481 -7
Branches 714 706 -8
==========================================
+ Hits 376 379 +3
+ Misses 469 463 -6
+ Partials 643 639 -4 |
|
Actually it turns out there was a bug related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoding Linux/x86_64 is a trap because it will silently do the
right thing only for users on that platform.
Closes: #88