image: Fix powerpc, add a test case for arch mapping
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
default-platform-fixes
branch
from
49bac3f
to
31224d0
Compare
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 25.57% 25.67% +0.09%
==========================================
Files 20 20
Lines 1482 1488 +6
Branches 707 710 +3
==========================================
+ Hits 379 382 +3
- Misses 464 466 +2
- Partials 639 640 +1 |
I happened to notice while skimming over this that Rust using `powerpc` is a strange outlier - the other key arch names AFAICS match the GNU ones (e.g. `s390x`, `riscv64`, `x86_64` etc). Now unfortunately, tests from dependencies aren't usually run by default by `cargo`. A major exception here is how Fedora packages crates and as part of the "build" of a crate the tests are run. So we will hopefully flush out any un-mapped architectures by that as well as anyone who actually goes to some effort to run the dependency tests.
cgwalters
force-pushed
the
default-platform-fixes
branch
from
31224d0
to
52e450e
Compare
saschagrunert
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to notice while skimming over this that Rust using
powerpcis a strange outlier - the other key arch names AFAICS match the GNU
ones (e.g.
s390x,riscv64,x86_64etc).Now unfortunately, tests from dependencies aren't usually run
by default by
cargo. A major exception here is how Fedora packagescrates and as part of the "build" of a crate the tests are run.
So we will hopefully flush out any un-mapped architectures by that
as well as anyone who actually goes to some effort to run the
dependency tests.