Fix TestContainerNoBinaryExists test, by making create behaviour similar to runc

[YJDoc2]

When creating, this will check if the binary to run as container process exists and if it has proper permissions in the init process.
If it doesn't, then generate an error in create.

Signed-off-by: Yashodhan Joshi yjdoc2@gmail.com

[codecov-commenter]

Codecov Report

Merging #1347 (88e7430) into main (489e94d) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
- Coverage   68.73%   68.48%   -0.26%     
==========================================
  Files         119      119              
  Lines       12601    12646      +45     
==========================================
- Hits         8661     8660       -1     
- Misses       3940     3986      +46     

[YJDoc2]

@utam0k I validated it with runc, and that too fails the test. The problem behind it is that we are validating the binary to be run in the init process exists, but the tests does not setup the binary at all. If we want to follow runc, we can skip this test, or we can choose to ignore the test in containerd validation. Unfortunately we have to make a call here. 😢 😭

[utam0k]

@YJDoc2 Thanks for the great investigation. I vote for skipping it

[utam0k]

@kzys May I ask you to help us? Is make integration not used in containerd? It appears that there is a test that fails even with runc. Is there something we missed?
https://containers.github.io/youki/developer/containerd_integration_test_using_youki.html

[kzys]

Let me take a look this week. We are at least using make integration.

[utam0k]

Let me take a look this week. We are at least using make integration.

🙏 Thanks.

[YJDoc2]

@utam0k after checking runc repo, I don't think they are using oci-integration tests anywhere in their CI or makefile. they seem to be using their self-written tests for integration.

[utam0k]

Let me take a look this week. We are at least using make integration.

@kzys Sorry, I thought we were talking about containerd, but we were talking about something else. I was mistaken🙇 Never mind.

[utam0k]

Thanks!