Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[actions] add workflow file for containerd integration testing #968

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[actions] add workflow file for containerd integration testing #968

merged 1 commit into from
Nov 30, 2022

Conversation

guni1192
Copy link
Contributor

@guni1192 guni1192 commented Jun 8, 2022 •
edited by gitpod-io bot
Loading

related: #531

@guni1192 guni1192 force-pushed the containerd-integration-test-on-actions branch 3 times, most recently from df155ad to e264e69 Compare June 8, 2022 14:50
@guni1192
Copy link
Contributor Author

guni1192 commented Jun 8, 2022

Current results
image

@utam0k
Copy link
Member

utam0k commented Nov 14, 2022

Hi, @guni1192 👋 We have great news! We have passed the contained integration test!!! So this PR has become more important for us. Feel free to let me know if you don't have enough time to complete this PR ;)
I'd like to respect your life, and if the youki team or other takes over this PR, we will try to leave your commits.
cc: @YJDoc2

@guni1192
Copy link
Contributor Author

@utam0k Excellent!!! I'm so sorry I've been out of touch!
I think I'll have more time this month, so can I continue?

@utam0k
Copy link
Member

utam0k commented Nov 14, 2022

I think I'll have more time this month, so can I continue?

@guni1192 Sure! I'm glad to hear that. But please keep in mind, if you need to overdo it to finish it, feel free to let me know. It is not important that it be done by the end of this month. What is most important is that you have fun developing this ;)

@guni1192 guni1192 force-pushed the containerd-integration-test-on-actions branch from e264e69 to 904aa8f Compare November 14, 2022 12:48
@guni1192
Copy link
Contributor Author

I appreciate your concern.

  • git rebase main
  • Rust version 1.64.0

After the above actions, two tests have failed and I will investigate the cause.

cat  9_Integration\ Test.txt | grep FAIL
2022-11-14T13:06:17.7705391Z --- FAIL: TestRegressionIssue6429 (0.73s)
2022-11-14T13:06:18.7449025Z --- FAIL: TestContainerNoBinaryExists (0.11s)
2022-11-14T13:07:57.3562973Z FAIL
2022-11-14T13:07:57.7430064Z FAIL	github.com/containerd/containerd/integration/client	156.571s

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 14, 2022

Hey, I re-tried the two cases on my machine through vagrant several times, and TestRegressionIssue6429 always passed, and TestContainerNoBinaryExists seems to fail. I'm trying to investigate that.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 15, 2022

@guni1192 can I ask you to rebase and check again after #1347 is merged? It should fix the TestContainerNoBinaryExists failure

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 28, 2022

@guni1192 can I ask you to rebase and re-run the tests now that #1347 is merged? Thank you :)

@guni1192
Copy link
Contributor Author

@YJDoc2 Yes. I will do it today!

@guni1192
[actions] add workflow file for containerd integration testing
cb718ae 
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
@guni1192 guni1192 force-pushed the containerd-integration-test-on-actions branch from 904aa8f to cb718ae Compare November 30, 2022 10:13
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Nov 30, 2022

@guni1192 @utam0k The CI is passing yay! 🎉 🎉 🎉
@guni1192 Thanks a lot for your efforts and this PR :)

@guni1192 guni1192 marked this pull request as ready for review November 30, 2022 10:58
utam0k
utam0k approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@utam0k
Copy link
Member

utam0k commented Nov 30, 2022

@guni1192 Awesome!!!

@utam0k utam0k merged commit 4f2dcec into youki-dev:main Nov 30, 2022
This was referenced Nov 30, 2022
Closed
Merged
@laupse laupse mentioned this pull request Feb 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guni1192 @utam0k @YJDoc2