Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump clap and use crate_version macro #259

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

akshatagarwl
Copy link
Contributor

There is also a crate_authors macro that can be used in a similar way

@Furisto
Copy link
Collaborator

Furisto commented Sep 4, 2021

@humancalico Looks good, but you need to run cargo fmt

@utam0k
Copy link
Member

utam0k commented Sep 5, 2021

@humancalico hmm. There was some suspicious log on the CI, and it was taking quite a while to test. I want to confirm, did the test passed on your machine?

@akshatagarwl
Copy link
Contributor Author

@utam0k the tests are kinda flaky. On three different runs I got different results each time and different tests failing

@utam0k
Copy link
Member

utam0k commented Sep 5, 2021

Oh.. Sorry, I create the PR to fix the unstable tests.
#267
However, I have a feeling that this error of ci at this PR is something different.

@akshatagarwl
Copy link
Contributor Author

The test_run_hook function is failing for me right now

running 29 tests
test container::state::tests::test_create_status ... ok
test container::container::tests::test_set_id ... ok
test container::container::tests::test_basic_getter ... ok
test container::state::tests::test_creating_status ... ok
test container::state::tests::test_running_status ... ok
test capabilities::tests::test_reset_effective ... ok
test container::state::tests::test_paused_status ... ok
test container::state::tests::test_stopped_status ... ok
test hooks::test::test_run_hook_timeout ... ignored
test namespaces::tests::test_apply_namespaces ... ok
test hooks::test::test_run_hook ... FAILED
test process::init::tests::test_cleanup_file_descriptors ... ok
test process::init::tests::test_get_open_fds ... ok
test signal::tests::test_conversion_from_string_should_be_failed ... ok
test process::channel::tests::test_channel_id_mapping_ack ... ok
test signal::tests::test_conversion_from_string ... ok
test utils::tests::test_get_cgroup_path ... ok
test utils::tests::test_join_absolute_path ... ok
test utils::tests::test_join_absolute_path_error ... ok
test utils::tests::test_parse_env ... ok
test process::channel::tests::test_channel_init_graceful_exit ... ok
test process::channel::tests::test_channel_init_ready ... ok
test process::channel::tests::test_channel_intermadiate_ready ... ok
test process::channel::tests::test_channel_intermedaite_graceful_exit ... ok
error: test failed, to rerun pass '--lib'
h

@Furisto
Copy link
Collaborator

Furisto commented Sep 5, 2021

@humancalico We have some problems with code coverage right now, so we have disabled it until further investigation. Please rebase and try again.

Signed-off-by: Akshat Agarwal <humancalico@disroot.org>
@akshatagarwl
Copy link
Contributor Author

@Furisto still getting the same failure

@Furisto
Copy link
Collaborator

Furisto commented Sep 5, 2021

lgtm

@Furisto Furisto merged commit 528de46 into youki-dev:main Sep 5, 2021
@akshatagarwl akshatagarwl deleted the crate_version branch September 5, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants