-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unstable the channel tests. #267
Conversation
a8e0e03
to
18ee2a7
Compare
} | ||
unistd::ForkResult::Child => { | ||
let pid = unistd::getpid(); | ||
sender | ||
.intermediate_ready(pid) | ||
.with_context(|| "Failed to send intermadiate ready")?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this because it would have overwritten the error message in the function that the test is running.
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 40.89% 41.22% +0.32%
==========================================
Files 15 15
Lines 1445 1458 +13
Branches 410 412 +2
==========================================
+ Hits 591 601 +10
+ Misses 649 645 -4
- Partials 205 212 +7 |
The test should not fail even if running in parallel, in theory. If it fails, I worry there is a race condition somewhere we should fix. |
Is this the error we saw? I can't find the error log in the referenced PR since they seem to be overridden in the PR.
|
I don't know the cause, but I want to merge this as soon as possible.