Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable the channel tests. #267

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Sep 5, 2021

I don't know the cause, but I want to merge this as soon as possible.

}
unistd::ForkResult::Child => {
let pid = unistd::getpid();
sender
.intermediate_ready(pid)
.with_context(|| "Failed to send intermadiate ready")?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it would have overwritten the error message in the function that the test is running.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2021

Codecov Report

Merging #267 (18ee2a7) into main (3fac283) will increase coverage by 0.32%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   40.89%   41.22%   +0.32%     
==========================================
  Files          15       15              
  Lines        1445     1458      +13     
  Branches      410      412       +2     
==========================================
+ Hits          591      601      +10     
+ Misses        649      645       -4     
- Partials      205      212       +7     

@Furisto Furisto merged commit b8442af into youki-dev:main Sep 5, 2021
@yihuaf
Copy link
Collaborator

yihuaf commented Sep 5, 2021

The test should not fail even if running in parallel, in theory. If it fails, I worry there is a race condition somewhere we should fix.

@yihuaf
Copy link
Collaborator

yihuaf commented Sep 5, 2021

Is this the error we saw? I can't find the error log in the referenced PR since they seem to be overridden in the PR.

failures:

---- hooks::test::test_run_hook stdout ----
Error: Broken pipe (os error 32)

Caused by:
    Broken pipe (os error 32)
thread 'hooks::test::test_run_hook' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/a178d0322ce20e33eac124758e837cbd80a6f633/library/test/src/lib.rs:193:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tty::tests::test_setup_console stdout ----
thread 'tty::tests::test_setup_console' panicked at 'called `Result::unwrap()` on an `Err` value: failed to open console-socket', src/tty.rs:157:40


failures:
    hooks::test::test_run_hook
    tty::tests::test_setup_console

test result: FAILED. 21 passed; 2 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass '--lib'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants