part of PR 340 adding test_setup_ptmx and test_setup_default_symlinks #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 70.18% 70.57% +0.39%
==========================================
Files 48 48
Lines 7409 7420 +11
==========================================
+ Hits 5200 5237 +37
+ Misses 2209 2183 -26 |
utam0k
reviewed
Oct 4, 2021
| @@ -251,25 +254,31 @@ impl RootFS { | |||
| } | |||
|
|
|||
| fn setup_ptmx(&self, rootfs: &Path) -> Result<()> { | |||
| if let Err(e) = remove_file(rootfs.join("dev/ptmx")) { | |||
| let ptmx = rootfs.join("dev/ptmx"); | |||
utam0k
approved these changes
Oct 4, 2021
tommady
deleted the
279-increate-the-code-coverage-of-src-rootfs-part-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested by separating #340 into small PRs
this one is the fourth part which is adding two test cases:
please help review 🙇🏻