Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 279 increate the code coverage of src rootfs #340

Conversation

tommady
Copy link
Collaborator

@tommady tommady commented Sep 27, 2021

#279
the rootfs part

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #340 (b8cac8b) into main (884428a) will increase coverage by 2.35%.
The diff coverage is 58.38%.

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   70.38%   72.73%   +2.35%     
==========================================
  Files          46       46              
  Lines        6790     7108     +318     
==========================================
+ Hits         4779     5170     +391     
+ Misses       2011     1938      -73     

@tommady tommady force-pushed the 279-increate-the-code-coverage-of-src-rootfs branch from 91521f7 to 6a04ddc Compare September 28, 2021 13:36
@yihuaf yihuaf changed the title 279 increate the code coverage of src rootfs [WIP] 279 increate the code coverage of src rootfs Sep 30, 2021
@yihuaf
Copy link
Collaborator

yihuaf commented Sep 30, 2021

I see this as draft, so changing the title to WIP. Let us know if anything you'd like to take a look :)

@tommady tommady force-pushed the 279-increate-the-code-coverage-of-src-rootfs branch from 7d9f4ba to 9d98c14 Compare September 30, 2021 01:50
@yihuaf
Copy link
Collaborator

yihuaf commented Oct 1, 2021

When you are done, can we break the PR into smaller PR since this now includes multiple tests? Thanks.

@tommady
Copy link
Collaborator Author

tommady commented Oct 2, 2021

When you are done, can we break the PR into smaller PR since this now includes multiple tests? Thanks.

Will do

@tommady
Copy link
Collaborator Author

tommady commented Oct 9, 2021

current rootfs test coverage is over 75%, so this PR will end up here.
image

@tommady tommady closed this Oct 9, 2021
@tommady tommady deleted the 279-increate-the-code-coverage-of-src-rootfs branch October 9, 2021 06:59
@utam0k
Copy link
Member

utam0k commented Oct 9, 2021

@tommady Of course, you may aim for 100% above 75.

@tommady
Copy link
Collaborator Author

tommady commented Oct 9, 2021

@tommady Of course, you may aim for 100% above 75.

Yes, I agreed but it may be easier to achieve that goal when cgroup v2 is added, or I am afraid it will let the person who develops with that too painful with conflicts.

So yes I can do many as I can in the future, but right now I think it can stop here for a while.

WDYT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants