Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part of PR 340 adding test_mount_to_container and separate rootfs file #365

Conversation

tommady
Copy link
Collaborator

@tommady tommady commented Oct 6, 2021

as requested by separating #340 into small PRs

this part is adding:

  1. test_mount_to_container
  2. separate rootfs.rs into pieces

please help review 🙇🏻

@tommady tommady force-pushed the 279-increate-the-code-coverage-of-src-rootfs-part-6 branch from ab15fe9 to 4707b17 Compare October 6, 2021 03:15
@utam0k
Copy link
Member

utam0k commented Oct 6, 2021

It's time to create a rootfs directory and separate the files.

@tommady
Copy link
Collaborator Author

tommady commented Oct 6, 2021

the only logic I modified at here
is because referenced to runC at here

runcC is using device type == bind as the condition.

@tommady tommady changed the title [WIP] part of PR 340 adding test_mount_to_container part of PR 340 adding test_mount_to_container and separate rootfs file Oct 6, 2021
@tommady tommady marked this pull request as ready for review October 6, 2021 16:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #365 (678b7f9) into main (68d2c0b) will increase coverage by 74.73%.
The diff coverage is 77.84%.

@@            Coverage Diff            @@
##           main     #365       +/-   ##
=========================================
+ Coverage      0   74.73%   +74.73%     
=========================================
  Files         0       51       +51     
  Lines         0     7763     +7763     
=========================================
+ Hits          0     5802     +5802     
- Misses        0     1961     +1961     

@utam0k
Copy link
Member

utam0k commented Oct 7, 2021

@tommady Instead of creatting an exclusive file for test, it is more natural in Rust to separate some functions into appropriate files based on some criteria, and put the tests associated with the functions into the same file.

@tommady tommady marked this pull request as draft October 7, 2021 15:12
@tommady tommady marked this pull request as ready for review October 8, 2021 06:35
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@utam0k utam0k merged commit c86c6bb into youki-dev:main Oct 8, 2021
@tommady tommady deleted the 279-increate-the-code-coverage-of-src-rootfs-part-6 branch October 11, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants