Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed panic on unwrapping $XDG_CACHE_HOME #11

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Fixed panic on unwrapping $XDG_CACHE_HOME #11

merged 3 commits into from
Aug 10, 2024

Conversation

Qustio
Copy link
Contributor

@Qustio Qustio commented Aug 10, 2024

When the program cannot find the $XDG_CACHE_HOME directory in the filesystem, it previously panicked. To address this issue, I've added a fallback mechanism to use $HOME/.cache/Iconic when $XDG_CACHE_HOME is not set.
Default path for $XDG_CACHE_HOME is specified by the Freedesktop-basedir specification: https://specifications.freedesktop.org/basedir-spec/latest/

Also I've formatted rust sources using cargo fmt

Scrambled777 and others added 2 commits August 5, 2024 23:05
Initial Hindi `hi` language translation.
@Qustio Qustio changed the title Fixed panic on unwrapping $XDG_HOME_CACHE Fixed panic on unwrapping $XDG_CACHE_HOME Aug 10, 2024
@youpie
Copy link
Owner

youpie commented Aug 10, 2024

thank you so much for this. however, can you revert the merge about the formatting. I can't easily see that way if you have added anything to the code.

After merging I'll format the code myself, and automate it if possible because I should really be doing that as standard

@Qustio
Copy link
Contributor Author

Qustio commented Aug 10, 2024

Done

@youpie
Copy link
Owner

youpie commented Aug 10, 2024

Great, ill merge it!

@youpie
Copy link
Owner

youpie commented Aug 10, 2024

Thank you very much for your work

@youpie youpie changed the base branch from main to dev August 10, 2024 19:37
@youpie youpie merged commit 85299c5 into youpie:dev Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants