Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logging related to shader loading #1394

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix logging related to shader loading #1394

wants to merge 2 commits into from

Conversation

l4desu-mizu
Copy link

Changelog

  • Category: Bug fixes
  • Description:
    • Fixed check for error when loading shaders for rules (inverted condition)
    • I think the opened shader files are not properly closed when successfully read

@l4desu-mizu
close file after read
1d4b3b3
@l4desu-mizu
fix misleading error message when using shader rules
c050f89 
* the logs were printing errors when loading shaders with rules,
  signalling there was an issue when loading a shader, but the shaders
  would load fine just the error message would print on success instead
  of error
@l4desu-mizu l4desu-mizu marked this pull request as ready for review December 9, 2024 21:49
@l4desu-mizu l4desu-mizu changed the title Minor fixes fix logging related to shader loading Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@l4desu-mizu