Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REG: orion2 .sink files are not being read #4078

Closed
neutrinoceros opened this issue Aug 13, 2022 · 3 comments · Fixed by #4081
Closed

REG: orion2 .sink files are not being read #4078

neutrinoceros opened this issue Aug 13, 2022 · 3 comments · Fixed by #4081
Labels
bug code frontends Things related to specific frontends release critical Highest priority (in a milestone)
Milestone

Comments

@neutrinoceros
Copy link
Member

Bug report

Bug summary

@drannarosen reported on Slack that the dev version of yt doesn't currently parses Orion2 datasets correctly, and a lot of derived fields are not being read at all.

Code for reproduction

I was able to reproduce the problem using data @drannarosen shared with me. The data sample is comprised of three files
data.0125.hdf5, data.0125.sink and orion2.ini

import yt

def test_orion2():
    ds = yt.load("data.0125.hdf5")
    assert ('io', 'particle_angmomen_x') in ds.field_list

Actual outcome
The test breaks on the main branch but passes on yt 4.0.5
I was able to bisect the regression to #3615
I'll inspect this a bit further. Worst case scenario I may just propose we revert that PR.

@neutrinoceros neutrinoceros added bug code frontends Things related to specific frontends release critical Highest priority (in a milestone) labels Aug 13, 2022
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Aug 13, 2022
@neutrinoceros
Copy link
Member Author

reverting doesn't work for this patch (too old and too big, at least one line was further edited since it was merged), so we have to find an actual fix.
for information @cphyc

@neutrinoceros
Copy link
Member Author

@drannarosen would you agree to share your example dataset with more than just me and post download links here too ?

@drannarosen
Copy link

@neutrinoceros, yes please feel free to share it for troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code frontends Things related to specific frontends release critical Highest priority (in a milestone)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants