-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Remove duplicate code in boxlib #3615
Conversation
Hey, there's a lot going on here, but it sounds like a good idea. |
1c6509d
to
f92abac
Compare
f92abac
to
f719788
Compare
f719788
to
3900ecb
Compare
Looks like you may have prematurely opened this for review, CI is failing. |
@zingale Can you peek at this real quick? It looks OK to me. |
it looks good to me. I haven't explicitly tested it (and don't really work with particles). |
Seems like we haven't been testing Orion2 data with sink files, and this patch broke that (#4078) edit: ah, of couse an automatic revert doesn't work because the patch is too big and too old. Welp, looks like we're in for an actual fix then. |
Removes duplication in boxlib frontend.
This is one step aimed at minimizing code duplication.
The duplicates are spotted using
Note that I have not attempted to fix all duplicate here.
I am not fully satisfied with the way I have de-duplicated code with chombo/boxlib. Any input is welcome!
I'd also be happy to split the PR in multiple chunks.