Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3615 #4081

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Revert #3615 #4081

merged 1 commit into from
Aug 16, 2022

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Aug 15, 2022

PR Summary

manual revert for #3615, fix #4078

ping @cphyc

@neutrinoceros neutrinoceros added bug release critical Highest priority (in a milestone) labels Aug 15, 2022
@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Aug 15, 2022
@neutrinoceros neutrinoceros marked this pull request as ready for review August 15, 2022 10:34
@neutrinoceros
Copy link
Member Author

seems like my revert is also broken, let's try that again

@neutrinoceros neutrinoceros marked this pull request as draft August 15, 2022 13:13
…e-code"

This reverts commit 7704cd0, reversing
changes made to b7dfe4a.
@neutrinoceros neutrinoceros marked this pull request as ready for review August 15, 2022 14:11
@matthewturk
Copy link
Member

Needs @cphyc to merge

@cphyc
Copy link
Member

cphyc commented Aug 16, 2022

hey @matthewturk I am very busy at the moment and till at least mid/late September. I'm fine with you merging this in the meantime.

@matthewturk matthewturk merged commit 452d3bf into yt-project:main Aug 16, 2022
@neutrinoceros neutrinoceros deleted the revert_3615 branch August 16, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release critical Highest priority (in a milestone)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REG: orion2 .sink files are not being read
3 participants