ENH: Update to fields used in Enzo answer testing #3998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwise77
added
infrastructure
jwise77
changed the title
matthewturk
reviewed
Jul 5, 2022
matthewturk
approved these changes
Jul 5, 2022
| @@ -122,8 +121,8 @@ def get_analytical_solution(self): | |||
| pos, dens, vel, pres, inte = np.loadtxt(self.solution_file, unpack=True) | |||
| exact = {} | |||
| exact["pos"] = pos | |||
There was a problem hiding this comment.
@jwise77 should this key be updated too or is there a reason not to ?
There was a problem hiding this comment.
It shouldn't be updated. This key is only used for interpolation purposes in the answer testing and not directly compared to the field data.
neutrinoceros
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR updates the field names to be tuples in the answer testing of the Enzo frontend. The
hubble_constantparameter is also not necessarily always written as a float (i.e. 1), so it is read as an int, which causes problems in unyt downstream. Forcing it to be float at initialization.