Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate numpy.testing reexports in yt.testing #4434

Merged
merged 3 commits into from
May 5, 2023

Conversation

neutrinoceros
Copy link
Member

closes #4433

@neutrinoceros neutrinoceros added the deprecation deprecate features or remove deprecated ones label May 3, 2023
@neutrinoceros neutrinoceros force-pushed the depr_npt_reexports branch 2 times, most recently from 3cb6894 to 35af2a0 Compare May 3, 2023 16:42
matthewturk
matthewturk previously approved these changes May 3, 2023
@neutrinoceros neutrinoceros added the refactor improve readability, maintainability, modularity label May 3, 2023
@neutrinoceros neutrinoceros marked this pull request as ready for review May 3, 2023 19:27
@neutrinoceros
Copy link
Member Author

had to rebase to resolve a conflict. @matthewturk can we merge this now ?

@jzuhone
Copy link
Contributor

jzuhone commented May 5, 2023

We should let the last test pass first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation deprecate features or remove deprecated ones refactor improve readability, maintainability, modularity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: deprecate re-exports of numpy.testing functions in yt.testing
3 participants