DEPR: deprecate unnecessary functions in the yt.testing namespace, update docs #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
deprecation
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
from
3cce3d6 to
1aa3bf5
Compare
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
2 times, most recently
from
b73c011 to
993a6a0
Compare
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
from
993a6a0 to
d070976
Compare
|
switching to draft until I get rid of all remaining self-triggered deprecation warnings in answer tests (which requires manual checking since nose cannot treat them as errors) |
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
3 times, most recently
from
800310a to
e4b855a
Compare
|
@yt-fido test this please |
matthewturk
reviewed
May 15, 2023
| @@ -265,7 +265,7 @@ union into a single ``darkmatter`` field. The ``all`` particle type is a | |||
| special case of this. | |||
|
|
|||
| To create a particle union, you need to import the ``ParticleUnion`` class from | |||
| ``yt.data_objects.particle_unions``, which you then create and pass into | |||
| ``yt.data_objects.unions``, which you then create and pass into | |||
jzuhone
previously approved these changes
May 15, 2023
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
2 times, most recently
from
cd8f929 to
b00b313
Compare
neutrinoceros
force-pushed
the
depr_assert_true_assert_less_equal
branch
from
b00b313 to
d5c760f
Compare
jzuhone
approved these changes
May 15, 2023
|
@matthewturk do you still want to have a look ? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
follow up to #4434, let's trim out the remaining fat in
yt.testing, and clean up some import statements that I missed in the first PRhalf of the "added" lines are from copying
yt.testing.expand_keywordsinto the only test module that uses it