Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds.ca broken #28309

Closed
5 tasks done
waptaff opened this issue Mar 2, 2021 · 0 comments
Closed
5 tasks done

rds.ca broken #28309

waptaff opened this issue Mar 2, 2021 · 0 comments

Comments

@waptaff
Copy link
Contributor

waptaff commented Mar 2, 2021

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2021.03.02
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.rds.ca/videos/Hockey/NationalHockeyLeague/teams/9/forum-du-5-a-7-jesperi-kotkaniemi-de-retour-de-finlande-3.1377606']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.03.02
[debug] Python version 3.8.7 (CPython) - Linux-5.10.12-gentoo-x86_64-AMD_Ryzen_5_3600X_6-Core_Processor-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.3.2, ffprobe 4.3.2, rtmpdump 2.4
[debug] Proxy map: {}
[RDS] forum-du-5-a-7-jesperi-kotkaniemi-de-retour-de-finlande: Downloading webpage
[debug] Using fake IP 99.233.244.72 (CA) as X-Forwarded-For.
[9c9media] 2083309: Downloading JSON metadata
ERROR: multiple content packages; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "./youtube-dl/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "./youtube-dl/youtube_dl/extractor/ninecninemedia.py", line 30, in _real_extract
    raise ExtractorError('multiple content packages')
youtube_dl.utils.ExtractorError: multiple content packages; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Downloads on rds.ca fail with above error. At about line 29 of extractor/ninecninemedia.py there is this check:

if len(content['ContentPackages']) > 1:
    raise ExtractorError('multiple content packages')

If I comment out the above check, download happens without error.

Not sure of the proper way to handle this, there is only one video on the page, referenced by two distinct content['ContentPackages'] that have different URLs but same content; suggestions:

  • Don't raise an exception, but emit a warning such as multiple (2) content packages; using the first one as default
  • Incorporate the ninecninemedia.py _real_extract method into rds.py's, with proper modification to download the first content['ContentPackages']
  • Somehow modify _real_extract so it can be told not to worry about multiple content['ContentPackages'] and only care about the Nth one.
github-actions bot added a commit to hellopony/youtube-dl that referenced this issue Mar 2, 2021
* https://github.com/ytdl-org/youtube-dl:
  [9c9media] fix extraction for videos with multiple ContentPackages(closes ytdl-org#28309)
  [bbc] correct catched exception type
  [bbc] add support for BBC Reel videos(closes ytdl-org#21870, closes ytdl-org#23660, closes ytdl-org#28268)
  release 2021.03.02
  [ChangeLog] Actualize [ci skip]
  [zdf] Rework extractors (closes ytdl-org#11606, closes ytdl-org#13473, closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274)
leshasmlesha pushed a commit to leshasmlesha/youtube-dl that referenced this issue Mar 7, 2021
leshasmlesha pushed a commit to leshasmlesha/youtube-dl that referenced this issue Mar 7, 2021
dirkf pushed a commit to dirkf/youtube-dl that referenced this issue Mar 16, 2021
leshasmlesha pushed a commit to leshasmlesha/youtube-dl that referenced this issue Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant