[3sat] Fix downloads from 3sat #28274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch also fixes the brokenness of 3sat.
dstftw
added a commit
that referenced
this pull request
Mar 1, 2021
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Mar 2, 2021
* https://github.com/ytdl-org/youtube-dl: [9c9media] fix extraction for videos with multiple ContentPackages(closes ytdl-org#28309) [bbc] correct catched exception type [bbc] add support for BBC Reel videos(closes ytdl-org#21870, closes ytdl-org#23660, closes ytdl-org#28268) release 2021.03.02 [ChangeLog] Actualize [ci skip] [zdf] Rework extractors (closes ytdl-org#11606, closes ytdl-org#13473, closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274)
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this pull request
Mar 7, 2021
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this pull request
Mar 7, 2021
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
This was referenced Mar 15, 2021
leshasmlesha
pushed a commit
to leshasmlesha/youtube-dl
that referenced
this pull request
Apr 3, 2021
…closes ytdl-org#17354, closes ytdl-org#21185, closes ytdl-org#26711, closes ytdl-org#27068, closes ytdl-org#27930, closes ytdl-org#28198, closes ytdl-org#28199, closes ytdl-org#28274) * Generalize unique video ids for zdf based extractors * Improve extraction * Fix 3sat and phoenix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @phihag, @dstftw, @remitamine, @jaimeMF, @yan12125 and all contributors,
thanks a stack for conceiving and maintaining
youtube-dl, we are glad that this excellent piece of software survived the recent woes.3sat is an important broadcaster in Central Europe serving quality content. So, fixing this extractor is important to us. We already found respective reports about 3sat being broken at #21185, #26711 and #28198. After that, we have been very happy to be able to find #27068 by @FliegendeWurst (thank you very much!), which apparently fixes this problem already, amongst other improvements.
So, we took the chance to rebase this patch and want to humbly ask to integrate it into the upcoming release. Please let me know if you need any changes to it.
With kind regards,
Andreas.
P.S.:
The original description of this patch by @FliegendeWurst is:
Using random samples, we are able to confirm it works for all broadcasters of ZDF, 3sat and Phoenix.
Checklist
I've reduced the checklist to the appropriate items and hope this is fine.
What is the purpose of this pull request?