[npr] Add new extractor #13446
Open
[npr] Add new extractor #13446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Jun 21, 2017
youtube_dl/extractor/npr.py
Outdated
| return formats | ||
|
|
||
|
|
||
| class NprPlaylistIE(NprBaseIE): |
There was a problem hiding this comment.
Don't change extractor name.
youtube_dl/extractor/npr.py
Outdated
| class NprIE(InfoExtractor): | ||
| _VALID_URL = r'https?://(?:www\.)?npr\.org/player/v2/mediaPlayer\.html\?.*\bid=(?P<id>\d+)' | ||
| class NprBaseIE(InfoExtractor): | ||
| def extract_info(self, id): |
There was a problem hiding this comment.
Don't shadow built-in names.
youtube_dl/extractor/npr.py
Outdated
| } | ||
|
|
||
| def _real_extract(self, url): | ||
| display_id = self._match_id(url) |
youtube_dl/extractor/npr.py
Outdated
|
|
||
| return json_data['list']['story'][0] | ||
|
|
||
| def extract_formats(self, media_info): |
youtube_dl/extractor/npr.py
Outdated
| class NprIE(InfoExtractor): | ||
| _VALID_URL = r'https?://(?:www\.)?npr\.org/player/v2/mediaPlayer\.html\?.*\bid=(?P<id>\d+)' | ||
| class NprBaseIE(InfoExtractor): | ||
| def extract_info(self, id): |
youtube_dl/extractor/npr.py
Outdated
| 'title': story.get('title', {}).get('$text'), | ||
| 'id': video.get('id'), | ||
| 'duration': int_or_none(video.get('duration', {}).get('$text')), | ||
| 'formats': self.extract_formats(video), |
There was a problem hiding this comment.
No url and formats at the same time.
youtube_dl/extractor/npr.py
Outdated
| return { | ||
| 'url': url, | ||
| 'display_id': display_id, | ||
| 'title': story.get('title', {}).get('$text'), |
|
Ok, pending fixes resolved and also problem with m3u8 formats. @dstftw |
|
The issue with #13440 is a site error. the hls url in the page source is 404: This is because the 200000 quality is not actually present on the server. An edited hls url does work: There is also html5 mp4 progressive url (600000 quality) in the page source which does work. It can be extended to the higher qualities using dirty heuristics or the quality values from the hls url. Best quality: https://ondemand.npr.org/npr-mp4/npr/ascvid/2017/06/20170619_ascvid_tigersjaw-n-2000000.mp4 |
|
Interesting, I will add this to the extractor. Any suggestion with rtmp? @stinkteeth |
|
rtmp seems to work okay if --resume is removed. Not sure why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
I rewritten Npr extractor and added support for #13440. However there is a problem with m3u8 playlists from NprVideo that returns error 404.
regards,
Giuseppe Fabiano