Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation / overview of new proposed extractors / sites #28054

Open
cypheron opened this issue Feb 3, 2021 · 4 comments
Open

Evaluation / overview of new proposed extractors / sites #28054

cypheron opened this issue Feb 3, 2021 · 4 comments
Assignees

Comments

@cypheron
Copy link

cypheron commented Feb 3, 2021

Hello everyone,
we're all seeing how this project is maintained only by a handful of people and number of issues and PR's is going to orbit.

Since many of the PR's are related to adding new extractors I went through all open AND closed PR's to give everyone an overview of how many and which new sites would potentially be added to ytdl. If someone is missing support for a specific site he/she/it can check here to see if the site is listed, and if yes, help with getting the site supported (merge the commits of the respective pull requests into their local repo to work on it), or if no, write and (maybe) contribute a new extractor.

Next to a summary I'm listing all "add new extractor" related pull requests / potentially new sites - both open pull requests and all closed, BUT merge-able pull requests. The latter is important to me because some people closed their pull requests due to lack of response from the maintainers - this second list has to be manually checked (because it can contain duplicates or already existing sites) to integrate those "lost" sites.

We're all here to contribute and make this project great. However, this does not work when contributions come to a dead-end. I would suggest setting up a donations pool for hiring a code reviewer responsible for adding new sites / maintaining site support (or something like that).

@maintainers: Feel free to update these lists as PR's are added / closed!

Summary: "Add new extractor" feature pull requests
Open: 140 (see list below)
Open, NO review comments: 95
Closed, total: 362
Closed, successfully merged: 113
Closed, without review comment (can have different reasons): 224
Closed, BUT merge-able (e.g. duplicates, or closed because of lack of response from maintainers): up to 120 (see list below)

List of new proposed sites (open):

List of potential new sites (closed, but merge-able):

@ghost
Copy link

ghost commented Feb 3, 2021

The mp4upload one I did years ago was pretty bad, I think there is a better one. But it does work

@AllanDaemon
Copy link

Yeah. Waiting 5 years for a merge request is somehow a dead end. I understand the limitations of the maintainers time. At the same time I want to help but I fell like stuck because of the lack of responses. I love this project and appreciate all the effort each one has given here, in particular the maintainers. But I'm afraid that the way it is today is hurting the project as many people that would help to contribute and perhaps become future maintainers are giving up. The effort to try to hire some of the maintainers to dedicate more seems an interesting idea that worth pursuing it.

@tmsbrg
Copy link
Contributor

tmsbrg commented May 10, 2021

@cypheron I'm the author of the VTV/tvnet extractor. It's actually been commited later by dstftw (thanks!) in a572ae6 so I think it can be removed from the closed list in this issue.

@Kagami
Copy link
Contributor

Kagami commented Jun 4, 2021

Remove: #18135 (merged)
Not mergeable, but conflicts/review comments are minor, maybe I will update it one day: #10129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants