Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schooltube] Add new extractor #13527

Closed
wants to merge 1 commit into from
Closed

[Schooltube] Add new extractor #13527

wants to merge 1 commit into from

Conversation

flomk
Copy link

@flomk flomk commented Jun 29, 2017

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Added a new extractor for education website schooltube.com - issue #13091.
Currently only works on single videos and doesn't work on channel page but I am working on adding support for that.

@dstftw dstftw closed this in b311b0e Jun 30, 2017
@flomk
Copy link
Author

flomk commented Jun 30, 2017

Why was this closed?
Never mind I see, will fix.

@dstftw
Copy link
Collaborator

dstftw commented Jun 30, 2017

It's covered by generic extractor.

@flomk
Copy link
Author

flomk commented Jun 30, 2017

Yes but the person who created the issue wanted more metadata such as keywords than is provided by the generic extractor.

@dstftw
Copy link
Collaborator

dstftw commented Jun 30, 2017

No such meta field keywords is recognized.

@flomk
Copy link
Author

flomk commented Jun 30, 2017

I didn't realize, my apologies.

@wertercatt
Copy link

keywords in this context is equivalent to the meta field tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants