[narando] add new extractor #18268
Closed
[narando] add new extractor #18268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…display_id attribute
dstftw
requested changes
Nov 29, 2018
youtube_dl/extractor/narando.py
Outdated
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage('https://narando.com/widget?r=' + video_id, video_id) | ||
| title = self._html_search_regex(r'<title>narando \| (.+?)</title>', webpage, 'title') | ||
| download_url = self._html_search_regex(r'.<div class="stream_url hide">\s*([^?]*)', webpage, 'download_url') |
youtube_dl/extractor/narando.py
Outdated
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage('https://narando.com/widget?r=' + video_id, video_id) | ||
| title = self._html_search_regex(r'<title>narando \| (.+?)</title>', webpage, 'title') | ||
| download_url = self._html_search_regex(r'.<div class="stream_url hide">\s*([^?]*)', webpage, 'download_url') |
|
Thanks for reviewing the code and suggesting improvements, I've implemented them. |
dstftw
reviewed
Dec 1, 2018
|
@dstftw are there any more things I need to fix or can this be merged? |
dstftw
requested changes
Jan 20, 2019
youtube_dl/extractor/narando.py
Outdated
|
|
||
|
|
||
| class NarandoPlayerIE(InfoExtractor): | ||
| IE_NAME = "narando:player" |
youtube_dl/extractor/narando.py
Outdated
| from .common import InfoExtractor | ||
|
|
||
|
|
||
| class NarandoPlayerIE(InfoExtractor): |
youtube_dl/extractor/narando.py
Outdated
|
|
||
| class NarandoPlayerIE(InfoExtractor): | ||
| IE_NAME = "narando:player" | ||
| _VALID_URL = r'https://narando\.com/widget\?r=(?P<id>\w+)' |
There was a problem hiding this comment.
Does not match https://narando.com/widget?foo=bar&r=b2t4t789kxgy9g7ms4rwjvvw.
youtube_dl/extractor/narando.py
Outdated
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage(url, video_id) | ||
| title = self._html_search_regex(r'<span class="clip-title">(.+?)</span>', webpage, 'title') | ||
| download_url = self._html_search_regex(r'.<div class="stream_url hide">\s*([^?]*)', webpage, 'download_url') |
youtube_dl/extractor/narando.py
Outdated
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage(url, video_id) | ||
| title = self._html_search_regex(r'<span class="clip-title">(.+?)</span>', webpage, 'title') | ||
| download_url = self._html_search_regex(r'.<div class="stream_url hide">\s*([^?]*)', webpage, 'download_url') |
There was a problem hiding this comment.
Do not capture empty strings.
youtube_dl/extractor/narando.py
Outdated
| } | ||
|
|
||
|
|
||
| class NarandoIE(InfoExtractor): |
youtube_dl/extractor/narando.py
Outdated
|
|
||
| class NarandoPlayerIE(InfoExtractor): | ||
| IE_NAME = "narando:player" | ||
| _VALID_URL = r'https://narando\.com/widget\?r=(?P<id>\w+)' |
There was a problem hiding this comment.
Does not match https://narando.com/r/b2t4t789kxgy9g7ms4rwjvvw.
youtube_dl/extractor/narando.py
Outdated
| video_id = self._match_id(url) | ||
| webpage = self._download_webpage(url, video_id) | ||
| title = self._html_search_regex(r'<h1 class="visible-xs h3">(.+?)</h1>', webpage, 'title') | ||
| player_id = self._html_search_regex(r'\s*https://narando.com/r/([^"]*)', webpage, 'player_id') |
There was a problem hiding this comment.
\s* is useless here. Again do not capture empty strings.
| player_id = self._html_search_regex(r'\s*https://narando.com/r/([^"]*)', webpage, 'player_id') | ||
| player_url = 'https://narando.com/widget?r=' + player_id | ||
|
|
||
| return { |
|
Thanks for reviewing again. I've made the requested changes. |
|
@dstftw Can you please take a look at this again? I've also added thumbnail extraction. |
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
dirkf
added
defunct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This implements an extractor for narando as specified in #18252 . This also adds an extractor for [narando:player], which can be used in the future for sites which embed the narando player.