Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compoundmedia] Add new extractor #18713

Closed
wants to merge 5 commits into from
Closed

Conversation

kevgrig
Copy link

@kevgrig kevgrig commented Jan 1, 2019

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

New extractor for https://www.compoundmedia.com/. No tests because all videos require authentication.

youtube_dl/extractor/compoundmedia.py Outdated Show resolved Hide resolved
youtube_dl/extractor/compoundmedia.py Outdated Show resolved Hide resolved
youtube_dl/extractor/compoundmedia.py Outdated Show resolved Hide resolved
youtube_dl/extractor/compoundmedia.py Outdated Show resolved Hide resolved
youtube_dl/extractor/compoundmedia.py Outdated Show resolved Hide resolved
@kevgrig
Copy link
Author

kevgrig commented Jan 4, 2019

@dstftw Hi, I believe all the requested changes are resolved and the Travis build passed. Can you please re-review?

@dstftw
Copy link
Collaborator

dstftw commented Jan 4, 2019

You must provide account credentials for any further work on this.

@kevgrig
Copy link
Author

kevgrig commented Jan 5, 2019

@dstftw I wasn't aware of that requirement. I don't like the security and privacy implications of that. Thanks for your consideration.

For any others interested, I simply patched my distribution-installed package:

$ echo "from .compoundmedia import CompoundMediaIE" | sudo tee -a /usr/lib/python3.7/site-packages/youtube_dl/extractor/extractors.py
$ sudo curl -o /usr/lib/python3.7/site-packages/youtube_dl/extractor/compoundmedia.py https://raw.githubusercontent.com/ytdl-org/youtube-dl/1f27d68da21a251b0c57e5e6dbba04a2f68414d2/youtube_dl/extractor/compoundmedia.py
$ cat >> ~/.netrc
machine compoundmedia login $EMAIL password $PASSWORD
Ctrl^D
$ youtube-dl -n https://www.compoundmedia.com/shows/...
[...]
[CompoundMedia] Logging in
[CompoundMedia] Requesting Metadata
[livestream] [...]: Downloading JSON metadata
[livestream] [...]: Downloading SMIL file
[livestream] [...]: Downloading m3u8 information
[livestream] [...]: Downloading f4m manifest
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: [...]
[download] Destination: [...].mp4
[download] 100% of [...]MiB in 01:35
[ffmpeg] Fixing malformed AAC bitstream in "[...].mp4"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants