Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mp4upload] Add new extractor #19103

Closed
wants to merge 1 commit into from
Closed

[mp4upload] Add new extractor #19103

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Added Mp4Upload support, which offers Anime, gaming videos. Known sources where you can get MP4upload embeded links exist like MasterAnime. Was included in one of my android apps as java, but I ported it to python because I thought it deserved to belong here in youtube-dl as well.

@dstftw dstftw closed this Feb 2, 2019
@ghost
Copy link
Author

ghost commented Feb 2, 2019

Ah crap, didn't notice it, well the other one seems inactive and has better code.. Maybe we should focus on it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant