Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AnimateGamer] Add new extractor #19654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AnimateGamer] Add new extractor #19654

wants to merge 1 commit into from

Conversation

lcy0321
Copy link

@lcy0321 lcy0321 commented Feb 24, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Add extractor for 巴哈姆特動畫瘋.
巴哈姆特動畫瘋 is a anime streaming service operated by 巴哈姆特電玩資訊站 (a Taiwanese gaming forum) in Taiwan.

youtube_dl/extractor/animategamer.py Outdated Show resolved Hide resolved
@lcy0321
Copy link
Author

lcy0321 commented Mar 17, 2019

@dstftw
I make _extract_m3u8_format receive all the arguments (add: encoding, data, headers, query, expected_status) that _download_webpage_handle() needs and pass to it.
And make AnimateGamer extractor call _extract_m3u8_format() directly instead of my custom _extract_m3u8_formats_with_http_headers().

@lcy0321 lcy0321 requested a review from dstftw September 22, 2019 14:09
@lcy0321
Copy link
Author

lcy0321 commented Dec 9, 2019

@dstftw
I notice that the parameters of _extract_m3u8_formats() I need was added in 7360c06
So I remove my change to that function in this PR.

Please review this PR if you have time, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants